Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2652153002: X87: [Turbofan] Implement call with spread bytecode in assembly code. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Turbofan] Implement call with spread bytecode in assembly code. port f9367847b0e97e7238b4bfefbec79c8fbbc11056 (r42632) original commit message: We can share almost all of the architecture-specific builtin code with super-call-with-spread. Info to port-writers: The code in CheckSpreadAndPushToStack has changed slightly from what was in Generate_ConstructWithSpread, in that we take the length of the spreaded parameters from the JSArray rather than the FixedArray backing store. BUG= Review-Url: https://codereview.chromium.org/2652153002 Cr-Commit-Position: refs/heads/master@{#42642} Committed: https://chromium.googlesource.com/v8/v8/+/bc1117ac03997c712c4134dd90afc18e929b9ae3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -142 lines) Patch
M src/builtins/x87/builtins-x87.cc View 7 chunks +163 lines, -142 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL. Thanks!
3 years, 11 months ago (2017-01-25 02:30:32 UTC) #2
chunyang.dai
On 2017/01/25 02:30:32, zhengxing.li wrote: > PTAL. Thanks! LGTM. thanks
3 years, 11 months ago (2017-01-25 04:42:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652153002/1
3 years, 11 months ago (2017-01-25 05:05:30 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 05:29:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bc1117ac03997c712c4134dd90afc18e929...

Powered by Google App Engine
This is Rietveld 408576698