Sanitize mini- and microdumps for webview

android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

Index: android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
diff --git a/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc b/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
index 43fe8cd6480ad3693f853a54f0e22e7bafaf2aa2..d27c4465b3c3945c128bc6a7cd8f665b8255bf59 100644
--- a/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
+++ b/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
@@ -25,6 +25,10 @@ namespace crash_reporter {
 
 namespace {
 
+#if !defined(COMPONENT_BUILD)
+void PrincipalMappingMarker() {}
+#endif
+
 class AwCrashReporterClient : public ::crash_reporter::CrashReporterClient {
  public:
   AwCrashReporterClient()
@@ -149,6 +153,11 @@ void EnableCrashReporter(const std::string& process_type, int crash_signal_fd) {
     client->set_crash_signal_fd(crash_signal_fd);
   }
   ::crash_reporter::SetCrashReporterClient(client);
+  breakpad::SetShouldSanitizeDumps(true);
+#if !defined(COMPONENT_BUILD)
+  breakpad::SetSkipDumpIfPrincipalMappingNotReferenced(
+        reinterpret_cast<uintptr_t>(&PrincipalMappingMarker));

[Robert Sesek, 2017/02/09 22:21:54]

I'd still probably just use EnableCrashReporter.

[Tobias Sargeant, 2017/02/10 13:24:05]

Done. Didn't also realise when moving the call to this file that there were more
non-method options now. Thanks for pointing it out.

+#endif
 
   bool is_browser_process =
       process_type.empty() ||