Sanitize mini- and microdumps for webview

android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/common/crash_reporter/aw_microdump_crash_reporter.h"
 
 #include "android_webview/common/aw_descriptors.h"
 #include "android_webview/common/aw_paths.h"
 #include "android_webview/common/aw_version_info_values.h"
 #include "base/android/build_info.h"
 #include "base/base_paths_android.h"
 #include "base/debug/dump_without_crashing.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/path_service.h"
 #include "base/scoped_native_library.h"
 #include "base/synchronization/lock.h"
 #include "build/build_config.h"
 #include "components/crash/content/app/breakpad_linux.h"
 #include "components/crash/content/app/crash_reporter_client.h"
 #include "content/public/common/content_switches.h"
 
 namespace android_webview {
 namespace crash_reporter {
 
 namespace {
 
+#if !defined(COMPONENT_BUILD)
+void PrincipalMappingMarker() {}
+#endif
+
 class AwCrashReporterClient : public ::crash_reporter::CrashReporterClient {
  public:
   AwCrashReporterClient()
       : dump_fd_(kAndroidMinidumpDescriptor), crash_signal_fd_(-1) {}
 
   // Does not use lock, can only be called immediately after creation.
   void set_crash_signal_fd(int fd) { crash_signal_fd_ = fd; }
 
   // crash_reporter::CrashReporterClient implementation.
   bool IsRunningUnattended() override { return false; }
@@ skipping 104 matching lines @@
     LOG(WARNING) << "Can't use breakpad to handle WebView crashes";
     return;
   }
 #endif
 
   AwCrashReporterClient* client = g_crash_reporter_client.Pointer();
   if (process_type == switches::kRendererProcess && crash_signal_fd != -1) {
     client->set_crash_signal_fd(crash_signal_fd);
   }
   ::crash_reporter::SetCrashReporterClient(client);
+  breakpad::SetShouldSanitizeDumps(true);
+#if !defined(COMPONENT_BUILD)
+  breakpad::SetSkipDumpIfPrincipalMappingNotReferenced(
+        reinterpret_cast<uintptr_t>(&PrincipalMappingMarker));

[Robert Sesek, 2017/02/09 22:21:54]

I'd still probably just use EnableCrashReporter.

[Tobias Sargeant, 2017/02/10 13:24:05]

Done. Didn't also realise when moving the call to this file that there were more
non-method options now. Thanks for pointing it out.

+#endif
 
   bool is_browser_process =
       process_type.empty() ||
       process_type == breakpad::kWebViewSingleProcessType ||
       process_type == breakpad::kBrowserProcessType;
   if (is_browser_process) {
     breakpad::InitCrashReporter("");
   } else {
     breakpad::InitNonBrowserCrashReporterForAndroid(process_type);
   }
@@ skipping 16 matching lines @@
 bool IsCrashReporterEnabled() {
   return breakpad::IsCrashReporterEnabled();
 }
 
 void SuppressDumpGeneration() {
   breakpad::SuppressDumpGeneration();
 }
 
 }  // namespace crash_reporter
 }  // namespace android_webview