Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2652133003: Disable ScopedHandleTest.MultiProcess under WinASan (Closed)

Created:
3 years, 11 months ago by Reid Kleckner
Modified:
3 years, 11 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews, grt+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ScopedHandleTest.MultiProcess under WinASan It crashes during shutdown on the bots for unknown reasons. Disable it until someone can reproduce the issue locally and fix it. R=thakis@chromium.org,scottmg@chromium.org BUG=685262 Review-Url: https://codereview.chromium.org/2652133003 Cr-Commit-Position: refs/heads/master@{#446073} Committed: https://chromium.googlesource.com/chromium/src/+/b6bb0148278cf4ade889633e16558a7d4b37d792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M base/win/scoped_handle_unittest.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Reid Kleckner
3 years, 11 months ago (2017-01-25 18:42:23 UTC) #1
Nico
lgtm https://build.chromium.org/p/chromium.fyi/builders/CrWinAsanCov%20tester?numbuilds=200 has a bunch of other failures too
3 years, 11 months ago (2017-01-25 18:43:34 UTC) #4
scottmg
lgtm
3 years, 11 months ago (2017-01-25 18:48:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652133003/1
3 years, 11 months ago (2017-01-25 19:01:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b6bb0148278cf4ade889633e16558a7d4b37d792
3 years, 11 months ago (2017-01-25 19:07:38 UTC) #12
Reid Kleckner
3 years, 11 months ago (2017-01-25 19:10:42 UTC) #13
Message was sent while issue was closed.
On 2017/01/25 18:43:34, Nico wrote:
> lgtm
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsanCov%20tester?numb...
> has a bunch of other failures too

I attempted to replicate the media_unittests failures, but they did not
reproduce locally. Realistically, our team doesn't have time to support Windows
sanitizer coverage. We should consider informing Abhishek, moving CF back down
to just regular ASan, which doesn't have such high maintenance, and turning off
the coverage bot.

Powered by Google App Engine
This is Rietveld 408576698