Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2652123003: Make ppapi/proxy child-process only (Closed)

Created:
3 years, 11 months ago by scottmg
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ppapi/proxy child-process only Only the constants seemed to be used from the browser, so pull them out to separate files. This removes ppapi/proxy from the browser dll, so that gn path out/Release //chrome:main_dll //ppapi/proxy is empty. (ppapi/proxy depends on //gin which depends on //v8 which is being removed from the browser.) R=brettw@chromium.org BUG=581766 Review-Url: https://codereview.chromium.org/2652123003 Cr-Commit-Position: refs/heads/master@{#446063} Committed: https://chromium.googlesource.com/chromium/src/+/3cab0ba1179fcb085af9efb0a2734c51b8d79be3

Patch Set 1 #

Patch Set 2 : component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -97 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc View 6 chunks +9 lines, -10 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc View 10 chunks +15 lines, -12 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/host/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/BUILD.gn View 1 4 chunks +13 lines, -1 line 0 comments Download
M ppapi/proxy/tcp_socket_resource_base.h View 1 chunk +0 lines, -20 lines 0 comments Download
M ppapi/proxy/tcp_socket_resource_base.cc View 4 chunks +5 lines, -10 lines 0 comments Download
A ppapi/proxy/tcp_socket_resource_constants.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ppapi/proxy/tcp_socket_resource_constants.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M ppapi/proxy/udp_socket_filter.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ppapi/proxy/udp_socket_resource_base.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ppapi/proxy/udp_socket_resource_base.cc View 2 chunks +5 lines, -8 lines 0 comments Download
A ppapi/proxy/udp_socket_resource_constants.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ppapi/proxy/udp_socket_resource_constants.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
scottmg
Do you mind looking at this one? Bill looked at me pretty blankly when I ...
3 years, 11 months ago (2017-01-25 00:21:47 UTC) #5
brettw
LGTM
3 years, 11 months ago (2017-01-25 00:23:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652123003/20001
3 years, 11 months ago (2017-01-25 18:29:03 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 18:35:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3cab0ba1179fcb085af9efb0a273...

Powered by Google App Engine
This is Rietveld 408576698