Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2652073004: Disable DX Capturer to unblock testing (Closed)

Created:
3 years, 11 months ago by joedow
Modified:
3 years, 11 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable DX Capturer to unblock testing A bug was found yesterday (crbug.com/684937) when prevents users from logging into Me2Me connections on Windows when using the DX capturer. The original author is on vacation so we are going to disable this functionality to unblock testing of M57 builds and development on M58 builds. BUG=685258 Review-Url: https://codereview.chromium.org/2652073004 Cr-Commit-Position: refs/heads/master@{#446117} Committed: https://chromium.googlesource.com/chromium/src/+/76a10b17535c0456f042817a69fa036f226b26a3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/host/desktop_environment_options.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
joedow
PTAL! Thanks, Joe
3 years, 11 months ago (2017-01-25 19:13:09 UTC) #6
Sergey Ulanov
lgtm https://codereview.chromium.org/2652073004/diff/1/remoting/host/desktop_environment_options.cc File remoting/host/desktop_environment_options.cc (right): https://codereview.chromium.org/2652073004/diff/1/remoting/host/desktop_environment_options.cc#newcode40 remoting/host/desktop_environment_options.cc:40: // TODO(joedow): Enable the DirectX capturer once crbug.com/684937 ...
3 years, 11 months ago (2017-01-25 19:44:04 UTC) #8
joedow
https://codereview.chromium.org/2652073004/diff/1/remoting/host/desktop_environment_options.cc File remoting/host/desktop_environment_options.cc (right): https://codereview.chromium.org/2652073004/diff/1/remoting/host/desktop_environment_options.cc#newcode40 remoting/host/desktop_environment_options.cc:40: // TODO(joedow): Enable the DirectX capturer once crbug.com/684937 is ...
3 years, 11 months ago (2017-01-25 20:31:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652073004/20001
3 years, 11 months ago (2017-01-25 20:32:26 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 21:05:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76a10b17535c0456f042817a69fa...

Powered by Google App Engine
This is Rietveld 408576698