Change ImmersiveContextMus to use DesktopCaptureClient.

Change ImmersiveContextMus to use DesktopCaptureClient.

Add a static function GetCaptureWindowGlobal() to DesktopCaptureClient
so that ImmersiveContextMus can use it to get the global capture window.

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=none

Review-Url: https://codereview.chromium.org/2652033003
Cr-Commit-Position: refs/heads/master@{#446035}
Committed: https://chromium.googlesource.com/chromium/src/+/7d6ec5cb69733e7bae2b5e70911df655de1e76a8

[riajiang, 2017-01-24 22:39:01]

riajiang@chromium.org changed reviewers:
+ sadrul@chromium.org, sky@chromium.org

[riajiang, 2017-01-24 22:39:01]

Separated this part out into a new CL as discussed. sadrul@ and sky@, PTAL,
thanks!

[sky, 2017-01-24 23:06:08]

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
File ui/views/widget/desktop_aura/desktop_capture_client.h (right):

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
ui/views/widget/desktop_aura/desktop_capture_client.h:40: static aura::Window*
GetCaptureWindowGlobal();
This name is ick! How about instead adding a function get the singleton
DesktopCaptureClient and then call GetGlobalCaptureWindow on it?

[sadrul, 2017-01-25 01:02:13]

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
File ui/views/widget/desktop_aura/desktop_capture_client.h (right):

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
ui/views/widget/desktop_aura/desktop_capture_client.h:40: static aura::Window*
GetCaptureWindowGlobal();
On 2017/01/24 23:06:08, sky wrote:
> This name is ick! How about instead adding a function get the singleton
> DesktopCaptureClient and then call GetGlobalCaptureWindow on it?

I believe the issue is that DesktopCaptureClient is not a singleton; each
DesktopNativeWidgetAura creates its own DesktopCaptureClient [1]. We *could*
have a singleton client, but looks like the current behaviour is deliberate to
work-around some issue on Windows [2].

1:
https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_nat...
2:
https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_cap...

[sky, 2017-01-25 04:47:48]

LGTM with improved docs.

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
File ui/views/widget/desktop_aura/desktop_capture_client.h (right):

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
ui/views/widget/desktop_aura/desktop_capture_client.h:40: static aura::Window*
GetCaptureWindowGlobal();
On 2017/01/25 01:02:13, sadrul wrote:
> On 2017/01/24 23:06:08, sky wrote:
> > This name is ick! How about instead adding a function get the singleton
> > DesktopCaptureClient and then call GetGlobalCaptureWindow on it?
> 
> I believe the issue is that DesktopCaptureClient is not a singleton; each
> DesktopNativeWidgetAura creates its own DesktopCaptureClient [1]. We *could*
> have a singleton client, but looks like the current behaviour is deliberate to
> work-around some issue on Windows [2].
> 
> 1:
>
https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_nat...
> 2:
>
https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_cap...

D'OH! You are certainly right. As I can't think of a better name, please
document that it is exactly the same as GetGlobalCaptureWindow, but static.

[sadrul, 2017-01-25 05:34:27]

lgtm with a small nit

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
File ui/views/widget/desktop_aura/desktop_capture_client.cc (right):

https://codereview.chromium.org/2652033003/diff/1/ui/views/widget/desktop_aur...
ui/views/widget/desktop_aura/desktop_capture_client.cc:21: i !=
capture_clients_->end(); ++i) {
Use auto

[riajiang, 2017-01-25 15:40:14]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 15:40:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 16:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 16:33:22]

Dry run: This issue passed the CQ dry run.

[riajiang, 2017-01-25 16:36:28]

The CQ bit was checked by riajiang@chromium.org

[riajiang, 2017-01-25 16:36:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2652033003/#ps20001
(title: "doc and auto")

[commit-bot: I haz the power, 2017-01-25 16:36:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-25 16:40:18]

The CQ bit was unchecked by sadrul@chromium.org

[sadrul, 2017-01-25 16:40:22]

https://codereview.chromium.org/2652033003/diff/20001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_capture_client.cc (right):

https://codereview.chromium.org/2652033003/diff/20001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_capture_client.cc:20: for (auto i =
capture_clients_->begin(); i != capture_clients_->end(); ++i) {
I was hoping something like this would work:

  for (auto* client : *capture_clients_) {
    if (client->capture_window_)
      return client->capture_window_;
  }

https://codereview.chromium.org/2652033003/diff/20001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_capture_client.cc:24: return NULL;
nullptr

[commit-bot: I haz the power, 2017-01-25 16:40:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485362188955490,
"parent_rev": "b93e84ceb1d053d1756709e656fade7ab3daa428", "commit_rev":
"7d6ec5cb69733e7bae2b5e70911df655de1e76a8"}

[commit-bot: I haz the power, 2017-01-25 16:41:11]

Description was changed from

==========
Change ImmersiveContextMus to use DesktopCaptureClient.

Add a static function GetCaptureWindowGlobal() to DesktopCaptureClient
so that ImmersiveContextMus can use it to get the global capture window.

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=none
==========

to

==========
Change ImmersiveContextMus to use DesktopCaptureClient.

Add a static function GetCaptureWindowGlobal() to DesktopCaptureClient
so that ImmersiveContextMus can use it to get the global capture window.

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=none

Review-Url: https://codereview.chromium.org/2652033003
Cr-Commit-Position: refs/heads/master@{#446035}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d6ec5cb69733e7bae2b5e70911d...
==========

[commit-bot: I haz the power, 2017-01-25 16:41:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d6ec5cb69733e7bae2b5e70911d...