Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2652013004: Remove bad check from UkmService::EnableReporting (Closed)

Created:
3 years, 11 months ago by Steven Holte
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove bad check from UkmService::EnableReporting This check will break tests on bots doing official builds, and the #if in MetricsServiceManager around the call to EnableReporting should accomplish the same thing. BUG= Review-Url: https://codereview.chromium.org/2652013004 Cr-Commit-Position: refs/heads/master@{#445917} Committed: https://chromium.googlesource.com/chromium/src/+/7b638658485d09fb68411aa0576ca41c9d330146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/ukm/ukm_service.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Steven Holte
3 years, 11 months ago (2017-01-25 01:28:52 UTC) #2
Nico
lgtm
3 years, 11 months ago (2017-01-25 01:50:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652013004/1
3 years, 11 months ago (2017-01-25 01:51:41 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 02:44:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b638658485d09fb68411aa0576c...

Powered by Google App Engine
This is Rietveld 408576698