Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2651903002: [wasm] No need to use multiple inheritance for `ModuleBytesEnv` (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
Reviewers:
bradnelson, bradn
CC:
v8-reviews_googlegroups.com, Clemens Hammacher, titzer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] No need to use multiple inheritance for `ModuleBytesEnv` Chromium coding standard (https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#Multiple-inheritance) In this case, a structure associating the 2 values is sufficient. BUG= Review-Url: https://codereview.chromium.org/2651903002 Cr-Commit-Position: refs/heads/master@{#42618} Committed: https://chromium.googlesource.com/v8/v8/+/8da82d30b861cdb6cc3c4276322a1592cb8ae4a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -47 lines) Patch
M src/compiler/wasm-compiler.cc View 8 chunks +17 lines, -14 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/wasm/wasm-module.h View 4 chunks +25 lines, -12 lines 0 comments Download
M src/wasm/wasm-module.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M src/wasm/wasm-text.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Mircea Trofin
3 years, 11 months ago (2017-01-24 06:46:50 UTC) #5
bradn
lgtm
3 years, 11 months ago (2017-01-24 06:57:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651903002/1
3 years, 11 months ago (2017-01-24 07:09:05 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 07:11:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8da82d30b861cdb6cc3c4276322a1592cb8...

Powered by Google App Engine
This is Rietveld 408576698