Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2651883007: Re-landing "UMA metrics for fractions of wheel and touch scrolls blocked on the main thread." (Closed)

Created:
3 years, 11 months ago by sahel
Modified:
3 years, 11 months ago
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, asvitkine+watch_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-landing "UMA metrics for fractions of wheel and touch scrolls blocked on the main thread." The original review-URL is https://codereview.chromium.org/2636583002 It got reverted because unittests were failing in Linux_Tests (dbg). I changed the tests to call ScrollEnd before calling ScrollBegin for the second time. TBR=holte@chromium.org BUG=626662, 626663 TEST=InputHandlerProxyTest.GestureScrollingThreadStatusHistogram, InputHandlerProxyTest.WheelScrollingThreadStatusHistogram Review-Url: https://codereview.chromium.org/2651883007 Cr-Commit-Position: refs/heads/master@{#445826} Committed: https://chromium.googlesource.com/chromium/src/+/b4ff2064283bc966a9de8b8c391dc8a3b168233d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -5 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +28 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 6 chunks +77 lines, -4 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 2 chunks +181 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
sahel
This cl is identical to https://codereview.chromium.org/2636583002 which got reverted because of failing unittests in linex_test(dbg). ...
3 years, 11 months ago (2017-01-24 20:48:44 UTC) #7
dtapuska
On 2017/01/24 20:48:44, sahel wrote: > This cl is identical to https://codereview.chromium.org/2636583002 which got > ...
3 years, 11 months ago (2017-01-24 21:01:47 UTC) #10
sahel
On 2017/01/24 21:01:47, dtapuska wrote: > On 2017/01/24 20:48:44, sahel wrote: > > This cl ...
3 years, 11 months ago (2017-01-24 21:05:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651883007/20001
3 years, 11 months ago (2017-01-24 21:06:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b4ff2064283bc966a9de8b8c391dc8a3b168233d
3 years, 11 months ago (2017-01-24 21:39:34 UTC) #17
Steven Holte
3 years, 11 months ago (2017-01-25 00:49:10 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698