Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2651843005: Make PDFs return find replies in the same form as regular pages. (Closed)

Created:
3 years, 11 months ago by paulmeyer
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PDFs return find replies in the same form as regular pages. BUG=684039, 55421 Review-Url: https://codereview.chromium.org/2651843005 Cr-Commit-Position: refs/heads/master@{#445763} Committed: https://chromium.googlesource.com/chromium/src/+/8c287600d86c43dd0bcadfb042ec98242f49e36e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
paulmeyer
3 years, 11 months ago (2017-01-24 15:22:22 UTC) #2
dsinclair
lgtm
3 years, 11 months ago (2017-01-24 15:29:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651843005/1
3 years, 11 months ago (2017-01-24 15:33:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/198948) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-24 15:37:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651843005/1
3 years, 11 months ago (2017-01-24 18:21:15 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 18:37:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c287600d86c43dd0bcadfb042ec...

Powered by Google App Engine
This is Rietveld 408576698