FrameGenerator should receive SurfaceInfo and use it in frame generation

FrameGenerator should receive SurfaceInfo and use it in frame generation

FrameGenerator::OnSurfaceCreated should get a full SurfaceInfo object,
as opposed to a surface id, and use that in frame generation instead of
depending on a window object.

FrameGenerator should not receive begin frames unless the SurfaceInfo
object or device_scale_factor_ changes.

Fixed a bug in SurfaceFactory, where the frame size was not calculated
properly.

BUG=683732
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2651843002
Cr-Commit-Position: refs/heads/master@{#445901}
Committed: https://chromium.googlesource.com/chromium/src/+/401c5932118fb24071348b6a6ee5ce1638a7d982

[Saman Sami, 2017-01-23 22:29:55]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 22:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-23 22:30:58]

Description was changed from

==========
FrameGenerator should not receive BeginFrames until SurfaceInfo changes

BUG=683732
==========

to

==========
FrameGenerator should not receive BeginFrames until SurfaceInfo changes

BUG=683732
==========

[Saman Sami, 2017-01-23 22:30:58]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Saman Sami, 2017-01-23 22:31:07]

PTAL

[Fady Samuel, 2017-01-23 22:34:27]

https://codereview.chromium.org/2651843002/diff/1/services/ui/ws/window_serve...
File services/ui/ws/window_server.cc (right):

https://codereview.chromium.org/2651843002/diff/1/services/ui/ws/window_serve...
services/ui/ws/window_server.cc:789: ->OnSurfaceCreated(surface_info, window);
While you're at it, could you please also check that window is the
"ActiveWindow" first here so that OnSurfaceCreated doesn't need to take in a
window?

[Saman Sami, 2017-01-23 23:10:43]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-01-23 23:10:50]

PTAL

[commit-bot: I haz the power, 2017-01-23 23:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-01-23 23:26:54]

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:114: shared_state->SetAll(gfx::Transform(),
output_rect.size(), output_rect,
You should scale the bounds like so:
https://cs.chromium.org/chromium/src/cc/layers/layer_impl.cc?sq=package:chrom...

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:143:
window->compositor_frame_sink_manager()->GetLatestSurfaceId();
Just use window_manager_surface_id_

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:154: const gfx::Rect
bounds_at_origin(window->bounds().size());
Just use surface_info_.size_in_pixels()

[commit-bot: I haz the power, 2017-01-24 00:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:18:52]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-01-24 02:52:32]

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:105: DrawWindow(render_pass.get(),
delegate_->GetActiveRootWindow());
We don't need GetActiveRootWindow here anymore. In fact, you can probably remove
FrameGeneratorDelegate::GetActiveRootWindow.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:136: if (!window || !window->visible())
Remove as well.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:139: if
(!window->compositor_frame_sink_manager())
This seems unnecessary.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:145: if (!default_surface_id.is_valid())
This should be a DCHECK instead.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:169: void
FrameGenerator::OnWindowDestroying(ServerWindow* window) {
Delete this.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.h (right):

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:40: class FrameGenerator : public
ServerWindowTracker,
FrameGenerator doesn't need to be a ServerWindowTracker.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:46: void set_device_scale_factor(float
device_scale_factor) {
set_device_scale_factor => SetDeviceScaleFactor and move implementation to cc
file since it's non-trivial.

Call SetNeedsBeginFrame inside implementation.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:70: void DrawWindow(cc::RenderPass* pass,
ServerWindow* window);
DrawWindow doesn't need to take in a ServerWindow.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:72: // ServerWindowObserver implementation.
Delete this.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:73: void OnWindowDestroying(ServerWindow*
window) override;
Delete this.

[Saman Sami, 2017-01-24 19:20:21]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 19:20:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 19:23:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:23:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-01-24 20:10:25]

Description was changed from

==========
FrameGenerator should not receive BeginFrames until SurfaceInfo changes

BUG=683732
==========

to

==========
FrameGenerator should not receive BeginFrames until SurfaceInfo changes

BUG=683732
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-24 20:10:57]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:11:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:13:51]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Saman Sami, 2017-01-24 20:26:37]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:27:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-24 20:29:59]

PTAL

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:105: DrawWindow(render_pass.get(),
delegate_->GetActiveRootWindow());
On 2017/01/24 02:52:31, Fady Samuel wrote:
> We don't need GetActiveRootWindow here anymore. In fact, you can probably
remove
> FrameGeneratorDelegate::GetActiveRootWindow.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:114: shared_state->SetAll(gfx::Transform(),
output_rect.size(), output_rect,
On 2017/01/23 23:26:54, Fady Samuel wrote:
> You should scale the bounds like so:
>
https://cs.chromium.org/chromium/src/cc/layers/layer_impl.cc?sq=package:chrom...

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:136: if (!window || !window->visible())
On 2017/01/24 02:52:31, Fady Samuel wrote:
> Remove as well. 

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:139: if
(!window->compositor_frame_sink_manager())
On 2017/01/24 02:52:31, Fady Samuel wrote:
> This seems unnecessary.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:143:
window->compositor_frame_sink_manager()->GetLatestSurfaceId();
On 2017/01/23 23:26:54, Fady Samuel wrote:
> Just use window_manager_surface_id_

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:145: if (!default_surface_id.is_valid())
On 2017/01/24 02:52:31, Fady Samuel wrote:
> This should be a DCHECK instead.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:154: const gfx::Rect
bounds_at_origin(window->bounds().size());
On 2017/01/23 23:26:54, Fady Samuel wrote:
> Just use surface_info_.size_in_pixels()

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:169: void
FrameGenerator::OnWindowDestroying(ServerWindow* window) {
On 2017/01/24 02:52:31, Fady Samuel wrote:
> Delete this.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.h (right):

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:40: class FrameGenerator : public
ServerWindowTracker,
On 2017/01/24 02:52:32, Fady Samuel wrote:
> FrameGenerator doesn't need to be a ServerWindowTracker.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:46: void set_device_scale_factor(float
device_scale_factor) {
On 2017/01/24 02:52:32, Fady Samuel wrote:
> set_device_scale_factor => SetDeviceScaleFactor and move implementation to cc
> file since it's non-trivial.
> 
> Call SetNeedsBeginFrame inside implementation.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:70: void DrawWindow(cc::RenderPass* pass,
ServerWindow* window);
On 2017/01/24 02:52:32, Fady Samuel wrote:
> DrawWindow doesn't need to take in a ServerWindow.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:72: // ServerWindowObserver implementation.
On 2017/01/24 02:52:32, Fady Samuel wrote:
> Delete this.

Done.

https://codereview.chromium.org/2651843002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.h:73: void OnWindowDestroying(ServerWindow*
window) override;
On 2017/01/24 02:52:32, Fady Samuel wrote:
> Delete this.

Done.

[Fady Samuel, 2017-01-24 20:43:28]

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:35: device_scale_factor_ =
device_scale_factor;
Let's not do work if we don't need to. Please add this to the top.

if (device_scale_factor_ == device_scale_factor)
  return;

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:66: // TODO(samans): Only tell FrameGenerator
about WM surface instead of all
nit: Remove this TODO because that's what you're doing now :-)

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:167: bounds_at_origin /* visible_layer_bounds
*/,
use scaled_bounds here too.

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/test_uti...
File services/ui/ws/test_utils.cc (right):

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/test_uti...
services/ui/ws/test_utils.cc:158: ServerWindow* root_window)
Remove this?

[commit-bot: I haz the power, 2017-01-24 20:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:47:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Saman Sami, 2017-01-24 21:10:25]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 21:11:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-24 21:13:12]

PTAL

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:35: device_scale_factor_ =
device_scale_factor;
On 2017/01/24 20:43:28, Fady Samuel wrote:
> Let's not do work if we don't need to. Please add this to the top.
> 
> if (device_scale_factor_ == device_scale_factor)
>   return;

Done.

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:66: // TODO(samans): Only tell FrameGenerator
about WM surface instead of all
On 2017/01/24 20:43:27, Fady Samuel wrote:
> nit: Remove this TODO because that's what you're doing now :-)

Done.

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:167: bounds_at_origin /* visible_layer_bounds
*/,
On 2017/01/24 20:43:27, Fady Samuel wrote:
> use scaled_bounds here too.

Done.

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/test_uti...
File services/ui/ws/test_utils.cc (right):

https://codereview.chromium.org/2651843002/diff/80001/services/ui/ws/test_uti...
services/ui/ws/test_utils.cc:158: ServerWindow* root_window)
On 2017/01/24 20:43:28, Fady Samuel wrote:
> Remove this?

Done.

[Fady Samuel, 2017-01-24 21:15:55]

LGTM

[Fady Samuel, 2017-01-24 21:15:55]

LGTM

[Saman Sami, 2017-01-24 21:23:36]

Description was changed from

==========
FrameGenerator should not receive BeginFrames until SurfaceInfo changes

BUG=683732
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
FrameGenerator should receive SurfaceInfo and use it in frame generation

FrameGenerator::OnSurfaceCreated should get a full SurfaceInfo object,
as opposed to a surface id, and use that in frame generation instead of
depending on a window object.

FrameGenerator should not receive begin frames unless the SurfaceInfo
object or device_scale_factor_ changes.

Fixed a bug in SurfaceFactory, where the frame size was not calculated
properly.

BUG=683732
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-24 21:24:02]

samans@chromium.org changed reviewers:
+ sky@chromium.org

[Saman Sami, 2017-01-24 21:24:17]

samans@chromium.org changed reviewers:
+ danakj@chromium.org

[Saman Sami, 2017-01-24 21:25:11]

sky: Please review services/
danakj: Please review cc/

[commit-bot: I haz the power, 2017-01-24 22:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 22:04:57]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Saman Sami, 2017-01-24 22:06:51]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:07:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-24 22:19:12]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:20:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-24 22:23:04]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:24:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-24 22:29:59]

LGTM

https://codereview.chromium.org/2651843002/diff/160001/services/ui/ws/display.h
File services/ui/ws/display.h (right):

https://codereview.chromium.org/2651843002/diff/160001/services/ui/ws/display...
services/ui/ws/display.h:147: ServerWindow* GetActiveRootWindow();
Style guide says declaration and definition should be in the same order. So,
move definition to match.

[danakj, 2017-01-24 22:37:19]

cc LGTM

https://codereview.chromium.org/2651843002/diff/160001/cc/surfaces/surface_fa...
File cc/surfaces/surface_factory_unittest.cc (right):

https://codereview.chromium.org/2651843002/diff/160001/cc/surfaces/surface_fa...
cc/surfaces/surface_factory_unittest.cc:680: render_pass->SetNew(1, gfx::Rect(0,
0, 5, 6), gfx::Rect(), gfx::Transform());
nit: Rect(5,6) is a bit more consise than Rect(0,0,5,6)

[Saman Sami, 2017-01-24 22:51:38]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-24 22:51:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, danakj@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2651843002/#ps180001
(title: "c")

[commit-bot: I haz the power, 2017-01-24 22:52:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:26:32]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Fady Samuel, 2017-01-24 23:29:30]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:30:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:42:01]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Saman Sami, 2017-01-25 00:56:23]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:57:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 01:30:47]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1485305783402600,
"parent_rev": "59c1ac58a65bb815893621feb68fe228e051a2b4", "commit_rev":
"401c5932118fb24071348b6a6ee5ce1638a7d982"}

[commit-bot: I haz the power, 2017-01-25 01:31:39]

Description was changed from

==========
FrameGenerator should receive SurfaceInfo and use it in frame generation

FrameGenerator::OnSurfaceCreated should get a full SurfaceInfo object,
as opposed to a surface id, and use that in frame generation instead of
depending on a window object.

FrameGenerator should not receive begin frames unless the SurfaceInfo
object or device_scale_factor_ changes.

Fixed a bug in SurfaceFactory, where the frame size was not calculated
properly.

BUG=683732
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
FrameGenerator should receive SurfaceInfo and use it in frame generation

FrameGenerator::OnSurfaceCreated should get a full SurfaceInfo object,
as opposed to a surface id, and use that in frame generation instead of
depending on a window object.

FrameGenerator should not receive begin frames unless the SurfaceInfo
object or device_scale_factor_ changes.

Fixed a bug in SurfaceFactory, where the frame size was not calculated
properly.

BUG=683732
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2651843002
Cr-Commit-Position: refs/heads/master@{#445901}
Committed:
https://chromium.googlesource.com/chromium/src/+/401c5932118fb24071348b6a6ee5...
==========

[commit-bot: I haz the power, 2017-01-25 01:31:40]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/401c5932118fb24071348b6a6ee5...