Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2651833003: [wasm] Move protected instruction info to RelocInfo (Closed)

Created:
3 years, 11 months ago by Eric Holk
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move protected instruction info to RelocInfo Previously this information was encoded in a FixedArray dangling off the Code object. This extra field seems to be responsible for increased memory usage, as seen in the linked bugs. In this change, we instead encode this in the RelocInfo and remove the field from the Code object. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=678583 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=671180 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=670733 Review-Url: https://codereview.chromium.org/2651833003 Cr-Commit-Position: refs/heads/master@{#42802} Committed: https://chromium.googlesource.com/v8/v8/+/91f8a063cc508f51a18ad9c69faf032552c9d012

Patch Set 1 #

Patch Set 2 : Remove some more protected instruction lists, fix RelocInfo. #

Patch Set 3 : Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into trap-relocinfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -72 lines) Patch
M src/assembler.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 2 4 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/code-generator.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 3 chunks +3 lines, -14 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/trap-handler/trap-handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 2 chunks +8 lines, -12 lines 0 comments Download
M src/x64/assembler-x64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eric Holk
3 years, 11 months ago (2017-01-23 23:42:52 UTC) #4
titzer
On 2017/01/23 23:42:52, Eric Holk wrote: I like this simplification! LGTM Sorry for the delay.
3 years, 10 months ago (2017-01-31 01:52:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651833003/40001
3 years, 10 months ago (2017-01-31 01:57:19 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 02:26:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/91f8a063cc508f51a18ad9c69faf032552c...

Powered by Google App Engine
This is Rietveld 408576698