Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: ios/showcase/toolbar/sc_toolbar_coordinator.mm

Issue 2651833002: [ios showcase]Configures Resource Bundle and adds Toolbar Coordinator (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/showcase/toolbar/sc_toolbar_coordinator.mm
diff --git a/ios/showcase/toolbar/sc_toolbar_coordinator.mm b/ios/showcase/toolbar/sc_toolbar_coordinator.mm
new file mode 100644
index 0000000000000000000000000000000000000000..6c20a2b12a25e8258533d0840d9d067974627623
--- /dev/null
+++ b/ios/showcase/toolbar/sc_toolbar_coordinator.mm
@@ -0,0 +1,27 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/showcase/toolbar/sc_toolbar_coordinator.h"
+
+#import "ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+@interface SCToolbarCoordinator ()
+@property(nonatomic, strong) ToolbarViewController* viewController;
lpromero 2017/01/24 01:54:27 BTW, why do you keep a pointer to that controller?
sczs 2017/01/24 18:32:22 Removed. I was going to start working on this fil
+@end
+
+@implementation SCToolbarCoordinator
+@synthesize baseViewController = _baseViewController;
+@synthesize viewController = _viewController;
+
+- (void)start {
+ self.viewController = [[ToolbarViewController alloc] init];
marq (ping after 24h) 2017/01/24 09:49:07 The toolbar doesn't set its own height; it relies
sczs 2017/01/24 18:32:22 Sorry for not being clearer (Though this feedback
marq (ping after 24h) 2017/01/25 09:29:22 That's fine. Small CLs are good!
+ self.viewController.title = @"Toolbar";
+ [self.baseViewController pushViewController:self.viewController animated:YES];
marq (ping after 24h) 2017/01/24 09:49:07 You should add a protocol alerter for <ToolbarComm
sczs 2017/01/24 18:32:22 Ditto.
+}
+
+@end

Powered by Google App Engine
This is Rietveld 408576698