Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Side by Side Diff: ios/showcase/toolbar/sc_toolbar_coordinator.mm

Issue 2651833002: [ios showcase]Configures Resource Bundle and adds Toolbar Coordinator (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "ios/showcase/toolbar/sc_toolbar_coordinator.h"
6
7 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h"
8
9 #if !defined(__has_feature) || !__has_feature(objc_arc)
10 #error "This file requires ARC support."
11 #endif
12
13 @interface SCToolbarCoordinator ()
14 @property(nonatomic, strong) ToolbarViewController* viewController;
lpromero 2017/01/24 01:54:27 BTW, why do you keep a pointer to that controller?
sczs 2017/01/24 18:32:22 Removed. I was going to start working on this fil
15 @end
16
17 @implementation SCToolbarCoordinator
18 @synthesize baseViewController = _baseViewController;
19 @synthesize viewController = _viewController;
20
21 - (void)start {
22 self.viewController = [[ToolbarViewController alloc] init];
marq (ping after 24h) 2017/01/24 09:49:07 The toolbar doesn't set its own height; it relies
sczs 2017/01/24 18:32:22 Sorry for not being clearer (Though this feedback
marq (ping after 24h) 2017/01/25 09:29:22 That's fine. Small CLs are good!
23 self.viewController.title = @"Toolbar";
24 [self.baseViewController pushViewController:self.viewController animated:YES];
marq (ping after 24h) 2017/01/24 09:49:07 You should add a protocol alerter for <ToolbarComm
sczs 2017/01/24 18:32:22 Ditto.
25 }
26
27 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698