Add .SingleTab and .MultiTabs suffix to Startup.FirstWebContents.MainNavigationStart histogram.

Add .SingleTab and .MultiTabs suffix to Startup.FirstWebContents.MainNavigationStart histogram.

BUG=684046
Review-Url: https://codereview.chromium.org/2651823002
Cr-Commit-Position: refs/heads/master@{#448348}
Committed: https://chromium.googlesource.com/chromium/src/+/19f104a391020bf6538f3fc78ce3c022096796ae

[gab, 2017-01-23 21:35:48]

gab@chromium.org changed reviewers:
+ fdoray@chromium.org

[gab, 2017-01-23 21:35:49]

Francois PTAL, thanks!

[gab, 2017-01-23 21:36:53]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 21:37:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:49:15]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-01-25 14:20:45]

lgtm

https://codereview.chromium.org/2651823002/diff/1/chrome/browser/metrics/firs...
File chrome/browser/metrics/first_web_contents_profiler.h (right):

https://codereview.chromium.org/2651823002/diff/1/chrome/browser/metrics/firs...
chrome/browser/metrics/first_web_contents_profiler.h:19: static void Start();
Should be a global function.
https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a...

[gab, 2017-01-26 19:57:55]

gab@chromium.org changed reviewers:
+ rkaplow@chromium.org

[gab, 2017-01-26 19:57:56]

Rob PTAL at metrics changes, thanks!

https://codereview.chromium.org/2651823002/diff/1/chrome/browser/metrics/firs...
File chrome/browser/metrics/first_web_contents_profiler.h (right):

https://codereview.chromium.org/2651823002/diff/1/chrome/browser/metrics/firs...
chrome/browser/metrics/first_web_contents_profiler.h:19: static void Start();
On 2017/01/25 14:20:45, fdoray wrote:
> Should be a global function.
>
https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a...

Right, I can follow up when I get access to a coding environment again.

[rkaplow, 2017-01-27 17:23:01]

lgtm

[gab, 2017-02-01 00:32:02]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:33:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 00:36:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:36:47]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2017-02-06 16:48:21]

https://codereview.chromium.org/2651823002/diff/1/chrome/browser/metrics/firs...
File chrome/browser/metrics/first_web_contents_profiler.h (right):

https://codereview.chromium.org/2651823002/diff/1/chrome/browser/metrics/firs...
chrome/browser/metrics/first_web_contents_profiler.h:19: static void Start();
On 2017/01/26 19:57:56, gab (travel until 5th) wrote:
> On 2017/01/25 14:20:45, fdoray wrote:
> > Should be a global function.
> >
>
https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a...
> 
> Right, I can follow up when I get access to a coding environment again.

Done in this one as part of rebase and renamed FirstWebContentsProfilerImpl back
to FirstWebContentsProfiler :)

[gab, 2017-02-06 16:48:25]

The CQ bit was checked by gab@chromium.org

[gab, 2017-02-06 16:48:25]

The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2651823002/#ps20001
(title: "static -> free method")

[commit-bot: I haz the power, 2017-02-06 16:48:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 16:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:50:45]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gab, 2017-02-06 17:56:36]

The CQ bit was checked by gab@chromium.org

[gab, 2017-02-06 17:56:36]

The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2651823002/#ps40001
(title: "rebase on r448292")

[commit-bot: I haz the power, 2017-02-06 17:57:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:29:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486403796654160,
"parent_rev": "61faa5671499375ac6aad46c219dec5cfdb86ef3", "commit_rev":
"19f104a391020bf6538f3fc78ce3c022096796ae"}

[commit-bot: I haz the power, 2017-02-06 19:30:18]

Description was changed from

==========
Add .SingleTab and .MultiTabs suffix to
Startup.FirstWebContents.MainNavigationStart histogram.

BUG=684046
==========

to

==========
Add .SingleTab and .MultiTabs suffix to
Startup.FirstWebContents.MainNavigationStart histogram.

BUG=684046

Review-Url: https://codereview.chromium.org/2651823002
Cr-Commit-Position: refs/heads/master@{#448348}
Committed:
https://chromium.googlesource.com/chromium/src/+/19f104a391020bf6538f3fc78ce3...
==========

[commit-bot: I haz the power, 2017-02-06 19:30:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/19f104a391020bf6538f3fc78ce3...