MD Settings: fix focus outline getting cut off in manage password page

MD Settings: fix focus outline getting cut off in manage password page

Using overflow:hidden around hyperlinks is causing focus outlines to get cut off. Switching to min-width: 0 has the same desired effect of forcing text-elide without cutting off the outline visuals.

BUG=684059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2651813002
Cr-Commit-Position: refs/heads/master@{#445765}
Committed: https://chromium.googlesource.com/chromium/src/+/f8344f4e824e081eadcc29b79edaa40dbdfef3b4

[scottchen, 2017-01-23 21:20:30]

Description was changed from

==========
MD Settings: fix focus outline getting cut off in manage password page

Using overflow:hidden around hyperlinks is causing focus outlines to get cut
off. Switching to min-width: 0 has the same desired effect of forcing text-elide
without cutting off the outline visuals.

BUG=684059
==========

to

==========
MD Settings: fix focus outline getting cut off in manage password page

Using overflow:hidden around hyperlinks is causing focus outlines to get cut
off. Switching to min-width: 0 has the same desired effect of forcing text-elide
without cutting off the outline visuals.

BUG=684059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-01-23 21:20:36]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 21:21:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottchen, 2017-01-23 21:22:40]

scottchen@chromium.org changed reviewers:
+ dpapad@chromium.org, hcarmona@chromium.org

[scottchen, 2017-01-23 21:22:41]

https://codereview.chromium.org/2651813002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.html (left):

https://codereview.chromium.org/2651813002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.html:102: 
Moving this to settings_shared_css.html to be reusable.

[scottchen, 2017-01-23 21:23:47]

On 2017/01/23 21:22:41, scottchen wrote:
>
https://codereview.chromium.org/2651813002/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/people_page/people_page.html (left):
> 
>
https://codereview.chromium.org/2651813002/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/people_page/people_page.html:102: 
> Moving this to settings_shared_css.html to be reusable.

screenshot after the fix:
http://imgur.com/a/EKRXk

[commit-bot: I haz the power, 2017-01-23 22:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:34:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scottchen, 2017-01-23 23:54:13]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 23:55:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-01-24 00:14:59]

lgtm

https://codereview.chromium.org/2651813002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2651813002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:36:
* ASCII. */
Nit:

* ASCII.
*/

[scottchen, 2017-01-24 00:23:17]

https://codereview.chromium.org/2651813002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2651813002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:36:
* ASCII. */
On 2017/01/24 00:14:59, dpapad wrote:
> Nit:
> 
> * ASCII.
> */

Done.

[scottchen, 2017-01-24 02:02:43]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 02:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 03:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 03:30:16]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2017-01-24 18:16:54]

lgtm

[scottchen, 2017-01-24 18:35:46]

The CQ bit was checked by scottchen@chromium.org

[scottchen, 2017-01-24 18:35:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2651813002/#ps40001
(title: "update comment format")

[commit-bot: I haz the power, 2017-01-24 18:36:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 18:41:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485282946254170,
"parent_rev": "0d62ebe1cdd137aff5c374f61330abb981ab2f44", "commit_rev":
"f8344f4e824e081eadcc29b79edaa40dbdfef3b4"}

[commit-bot: I haz the power, 2017-01-24 18:42:24]

Description was changed from

==========
MD Settings: fix focus outline getting cut off in manage password page

Using overflow:hidden around hyperlinks is causing focus outlines to get cut
off. Switching to min-width: 0 has the same desired effect of forcing text-elide
without cutting off the outline visuals.

BUG=684059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: fix focus outline getting cut off in manage password page

Using overflow:hidden around hyperlinks is causing focus outlines to get cut
off. Switching to min-width: 0 has the same desired effect of forcing text-elide
without cutting off the outline visuals.

BUG=684059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2651813002
Cr-Commit-Position: refs/heads/master@{#445765}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8344f4e824e081eadcc29b79eda...
==========

[commit-bot: I haz the power, 2017-01-24 18:42:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f8344f4e824e081eadcc29b79eda...