[wasm] Test argument passing in the interpreter entry

[wasm] Test argument passing in the interpreter entry

Test the wasm interpreter entry stub by creating two wasm functions A
and B, make A pass arguments to B, then redirect B to be executed in the
interpreter.
Test different number and types or arguments.

BUG=v8:5822
R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2651793003
Cr-Commit-Position: refs/heads/master@{#43353}
Committed: https://chromium.googlesource.com/v8/v8/+/e6819ee286c2041f9a668346f519e6fb7db9708f

[Clemens Hammacher, 2017-01-24 10:43:16]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 10:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 10:46:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 10:46:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Clemens Hammacher, 2017-01-24 10:46:21]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 10:46:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-01-24 10:47:30]

clemensh@chromium.org changed reviewers:
- titzer@chromium.org

[commit-bot: I haz the power, 2017-01-24 10:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 10:49:44]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21415)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21501)

[Clemens Hammacher, 2017-01-24 10:54:37]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 10:54:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 10:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 10:58:34]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21418)

[Clemens Hammacher, 2017-01-24 20:22:00]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:26:59]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21455)

[Clemens Hammacher, 2017-01-25 13:22:37]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 13:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 13:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 13:54:54]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-01-25 14:31:01]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 14:31:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 14:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:37:43]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Clemens Hammacher, 2017-01-25 15:02:16]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 15:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 15:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 15:08:47]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Clemens Hammacher, 2017-01-25 15:10:01]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 15:10:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 15:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 15:40:32]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-01-25 15:41:57]

clemensh@chromium.org changed reviewers:
+ titzer@chromium.org

[Clemens Hammacher, 2017-01-25 15:42:52]

This is a monster of C++ templates, but it is able to test the interpreter entry
for different types of inputs, automatically creating the code for two wasm
functions and calling the outer one.
WDYT? Worth it?

https://codereview.chromium.org/2651793003/diff/140001/test/cctest/wasm/test-...
File test/cctest/wasm/test-wasm-interpreter-entry.cc (right):

https://codereview.chromium.org/2651793003/diff/140001/test/cctest/wasm/test-...
test/cctest/wasm/test-wasm-interpreter-entry.cc:1: // Copyright 2016 the V8
project authors. All rights reserved.
Will change this to 2017.

[Clemens Hammacher, 2017-02-15 14:54:38]

On 2017/01/25 at 15:42:52, Clemens Hammacher wrote:
> This is a monster of C++ templates, but it is able to test the interpreter
entry for different types of inputs, automatically creating the code for two
wasm functions and calling the outer one.
> WDYT? Worth it?

This one is still rotting here. Any opinion on it?

[titzer, 2017-02-16 13:22:10]

https://codereview.chromium.org/2651793003/diff/140001/test/cctest/wasm/test-...
File test/cctest/wasm/test-wasm-interpreter-entry.cc (right):

https://codereview.chromium.org/2651793003/diff/140001/test/cctest/wasm/test-...
test/cctest/wasm/test-wasm-interpreter-entry.cc:2: // Use of this source code is
governed by a BSD-style license that can be
After some consideration, I think it'd be better to avoid the template logic and
just blat out the various testcases by hand, e.g. one for i32, one for f32, etc,
and then some examples of combinations.

[Clemens Hammacher, 2017-02-21 14:20:18]

Description was changed from

==========
[wasm] Test interpreter entry for different types

Add tests which pass different number and types of arguments from
compiled wasm code to the interpreter entry.

BUG=v8:5822
R=titzer@chromium.org
==========

to

==========
[wasm] Test argument passing in the interpreter entry

Test the wasm interpreter entry stub by creating two wasm functions A
and B, make A pass arguments to B, then redirect B to be executed in the
interpreter.
Test different number and types or arguments.

BUG=v8:5822
R=titzer@chromium.org
==========

[Clemens Hammacher, 2017-02-21 14:22:54]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 14:23:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 14:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 14:29:34]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Clemens Hammacher, 2017-02-21 14:36:26]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 14:36:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-02-21 14:37:39]

https://codereview.chromium.org/2651793003/diff/140001/test/cctest/wasm/test-...
File test/cctest/wasm/test-wasm-interpreter-entry.cc (right):

https://codereview.chromium.org/2651793003/diff/140001/test/cctest/wasm/test-...
test/cctest/wasm/test-wasm-interpreter-entry.cc:2: // Use of this source code is
governed by a BSD-style license that can be
On 2017/02/16 at 13:22:10, titzer wrote:
> After some consideration, I think it'd be better to avoid the template logic
and just blat out the various testcases by hand, e.g. one for i32, one for f32,
etc, and then some examples of combinations.

Done. It's about the same size (loc) as before, tests a bit less, but is more
readable now.

[commit-bot: I haz the power, 2017-02-21 14:43:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 14:43:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Clemens Hammacher, 2017-02-21 15:11:55]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:12:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:38:54]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-02-21 17:09:08]

This now depends on mircaes CL about finalizing managed objects, and now it's
green (no more memory leaks).

[titzer, 2017-02-21 17:13:37]

lgtm modulo naming nit

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-interpre...
File src/wasm/wasm-interpreter.cc (right):

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-interpre...
src/wasm/wasm-interpreter.cc:1066: ++interpreted_functions_;
called_functions_?

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-objects.h
File src/wasm/wasm-objects.h (right):

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-objects....
src/wasm/wasm-objects.h:444: uint64_t NumInterpretedFunctions();
Same here. NumInterpretedCalls?

[Clemens Hammacher, 2017-02-21 17:50:34]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 17:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-02-21 17:51:14]

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-interpre...
File src/wasm/wasm-interpreter.cc (right):

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-interpre...
src/wasm/wasm-interpreter.cc:1066: ++interpreted_functions_;
On 2017/02/21 at 17:13:37, titzer wrote:
> called_functions_?

Renamed to num_interpreted_calls_.
called_functions_ might be misleading once we support calling imported
functions. Those will not be counted.

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-objects.h
File src/wasm/wasm-objects.h (right):

https://codereview.chromium.org/2651793003/diff/200001/src/wasm/wasm-objects....
src/wasm/wasm-objects.h:444: uint64_t NumInterpretedFunctions();
On 2017/02/21 at 17:13:37, titzer wrote:
> Same here. NumInterpretedCalls?

Done.

[commit-bot: I haz the power, 2017-02-21 18:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:15:37]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-02-21 18:19:25]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2017-02-21 18:19:25]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2651793003/#ps220001
(title: "Naming")

[commit-bot: I haz the power, 2017-02-21 18:19:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 18:21:32]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1487701165144570,
"parent_rev": "cc805e42af5ace69c5f52cc3fa50ed509a30fe28", "commit_rev":
"e6819ee286c2041f9a668346f519e6fb7db9708f"}

[commit-bot: I haz the power, 2017-02-21 18:21:38]

Description was changed from

==========
[wasm] Test argument passing in the interpreter entry

Test the wasm interpreter entry stub by creating two wasm functions A
and B, make A pass arguments to B, then redirect B to be executed in the
interpreter.
Test different number and types or arguments.

BUG=v8:5822
R=titzer@chromium.org
==========

to

==========
[wasm] Test argument passing in the interpreter entry

Test the wasm interpreter entry stub by creating two wasm functions A
and B, make A pass arguments to B, then redirect B to be executed in the
interpreter.
Test different number and types or arguments.

BUG=v8:5822
R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2651793003
Cr-Commit-Position: refs/heads/master@{#43353}
Committed:
https://chromium.googlesource.com/v8/v8/+/e6819ee286c2041f9a668346f519e6fb7db...
==========

[commit-bot: I haz the power, 2017-02-21 18:21:40]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/v8/v8/+/e6819ee286c2041f9a668346f519e6fb7db...