Cleanup in components/search and chrome/browser/search

Cleanup in components/search and chrome/browser/search

Remove unused function
IsQueryExtractionAllowedForURL

Remove pointless functions
ShouldReuseInstantSearchBasePage
ShouldPrefetchSearchResults
(these always returned IsInstantExtendedAPIEnabled)

Move IsSuitableURLForInstant to c/b/search.cc (only call site)

Remove unused field trial functions

BUG=627747
Review-Url: https://codereview.chromium.org/2651763002
Cr-Commit-Position: refs/heads/master@{#445715}
Committed: https://chromium.googlesource.com/chromium/src/+/fb44744e06573d880f3c99d1aec1e960bb18dc31

[Marc Treib, 2017-01-23 18:01:13]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 18:02:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 18:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:42:53]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-01-24 08:57:19]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-01-24 08:57:20]

PTAL!

https://codereview.chromium.org/2651763002/diff/1/chrome/browser/search/searc...
File chrome/browser/search/search.cc (left):

https://codereview.chromium.org/2651763002/diff/1/chrome/browser/search/searc...
chrome/browser/search/search.cc:395: return ShouldPrefetchSearchResults() ?
GetInstantURL(profile, true) : GURL();
GetInstantURL has an equivalent check, so this one isn't needed.

https://codereview.chromium.org/2651763002/diff/1/chrome/browser/search/search.h
File chrome/browser/search/search.h (left):

https://codereview.chromium.org/2651763002/diff/1/chrome/browser/search/searc...
chrome/browser/search/search.h:129: // The following APIs are exposed for use in
tests only.
Not true, it's used in non-testing code too.

[sfiera, 2017-01-24 11:16:49]

LGTM

https://codereview.chromium.org/2651763002/diff/1/components/search/search.cc
File components/search/search.cc (right):

https://codereview.chromium.org/2651763002/diff/1/components/search/search.cc...
components/search/search.cc:107: FieldTrialFlags::const_iterator i;
Move declaration into loop?

[Marc Treib, 2017-01-24 12:37:07]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 12:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-01-24 12:37:22]

https://codereview.chromium.org/2651763002/diff/1/components/search/search.cc
File components/search/search.cc (right):

https://codereview.chromium.org/2651763002/diff/1/components/search/search.cc...
components/search/search.cc:107: FieldTrialFlags::const_iterator i;
On 2017/01/24 11:16:49, sfiera wrote:
> Move declaration into loop?

I replaced the loop with a for-each. Iterators must die :)

[commit-bot: I haz the power, 2017-01-24 13:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 13:29:46]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-01-24 14:16:22]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-01-24 14:16:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sfiera@chromium.org
Link to the patchset: https://codereview.chromium.org/2651763002/#ps20001
(title: "for each")

[commit-bot: I haz the power, 2017-01-24 14:16:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 14:20:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485267382315660,
"parent_rev": "6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14", "commit_rev":
"fb44744e06573d880f3c99d1aec1e960bb18dc31"}

[commit-bot: I haz the power, 2017-01-24 14:20:40]

Description was changed from

==========
Cleanup in components/search and chrome/browser/search

Remove unused function
IsQueryExtractionAllowedForURL

Remove pointless functions
ShouldReuseInstantSearchBasePage
ShouldPrefetchSearchResults
(these always returned IsInstantExtendedAPIEnabled)

Move IsSuitableURLForInstant to c/b/search.cc (only call site)

Remove unused field trial functions

BUG=627747
==========

to

==========
Cleanup in components/search and chrome/browser/search

Remove unused function
IsQueryExtractionAllowedForURL

Remove pointless functions
ShouldReuseInstantSearchBasePage
ShouldPrefetchSearchResults
(these always returned IsInstantExtendedAPIEnabled)

Move IsSuitableURLForInstant to c/b/search.cc (only call site)

Remove unused field trial functions

BUG=627747

Review-Url: https://codereview.chromium.org/2651763002
Cr-Commit-Position: refs/heads/master@{#445715}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb44744e06573d880f3c99d1aec1...
==========

[commit-bot: I haz the power, 2017-01-24 14:20:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb44744e06573d880f3c99d1aec1...