Remove dead code related to Notification View Bubble

Remove dead code related to Notification View Bubble

BUG=630641
Review-Url: https://codereview.chromium.org/2651723002
Cr-Commit-Position: refs/heads/master@{#445512}
Committed: https://chromium.googlesource.com/chromium/src/+/73d9d4ac7b327770e2b8a4d8782abe5a62a2c91c

[yiyix, 2017-01-23 16:43:11]

Description was changed from

==========
dead code

BUG=
==========

to

==========
Remove dead code related to Notification View Bubble

BUG=630641
==========

[yiyix, 2017-01-23 16:43:19]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 16:43:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2017-01-23 16:51:15]

yiyix@chromium.org changed reviewers:
+ jamescook@chromium.org

[yiyix, 2017-01-23 16:51:16]

@jamescook, could you please take a look at this change? Thank you.

[James Cook, 2017-01-23 17:11:01]

LGTM

https://codereview.chromium.org/2651723002/diff/1/ash/common/system/status_ar...
File ash/common/system/status_area_widget.cc (right):

https://codereview.chromium.org/2651723002/diff/1/ash/common/system/status_ar...
ash/common/system/status_area_widget.cc:137:
web_notification_tray_->ShouldBlockShelfAutoHide()))
Q: It seems a little odd that we still have this code, but we don't have the
IsMouseInNotificationBubble below. Any idea why IsMouseInNotification always
returned false?

https://codereview.chromium.org/2651723002/diff/1/ash/common/system/status_ar...
ash/common/system/status_area_widget.cc:151: return (system_tray_ &&
system_tray_->IsMouseInNotificationBubble());
nit: no parens

[commit-bot: I haz the power, 2017-01-23 17:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 17:15:01]

Dry run: This issue passed the CQ dry run.

[yiyix, 2017-01-23 21:15:33]

@jamescook, sorry, i forget to include few more lines of deadcode in my previous
review. in System_tray.h & System_tray.cc class.

https://codereview.chromium.org/2651723002/diff/1/ash/common/system/status_ar...
File ash/common/system/status_area_widget.cc (right):

https://codereview.chromium.org/2651723002/diff/1/ash/common/system/status_ar...
ash/common/system/status_area_widget.cc:137:
web_notification_tray_->ShouldBlockShelfAutoHide()))
On 2017/01/23 17:11:01, James Cook wrote:
> Q: It seems a little odd that we still have this code, but we don't have the
> IsMouseInNotificationBubble below. Any idea why IsMouseInNotification always
> returned false?

I think it's from the message bubble removal,
https://chromiumcodereview.appspot.com/18247002.

https://codereview.chromium.org/2651723002/diff/1/ash/common/system/status_ar...
ash/common/system/status_area_widget.cc:151: return (system_tray_ &&
system_tray_->IsMouseInNotificationBubble());
On 2017/01/23 17:11:01, James Cook wrote:
> nit: no parens

Done.

[yiyix, 2017-01-23 21:17:02]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 21:17:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-01-23 21:23:13]

still lgtm. Thanks for cleaning up this stuff.

[commit-bot: I haz the power, 2017-01-23 22:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:04:59]

Dry run: This issue passed the CQ dry run.

[yiyix, 2017-01-23 22:12:48]

The CQ bit was checked by yiyix@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:20:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485209568880540,
"parent_rev": "c086c48ae1b2d5de49ef524c30baaedb2dc1d21b", "commit_rev":
"73d9d4ac7b327770e2b8a4d8782abe5a62a2c91c"}

[commit-bot: I haz the power, 2017-01-23 22:21:13]

Description was changed from

==========
Remove dead code related to Notification View Bubble

BUG=630641
==========

to

==========
Remove dead code related to Notification View Bubble

BUG=630641

Review-Url: https://codereview.chromium.org/2651723002
Cr-Commit-Position: refs/heads/master@{#445512}
Committed:
https://chromium.googlesource.com/chromium/src/+/73d9d4ac7b327770e2b8a4d8782a...
==========

[commit-bot: I haz the power, 2017-01-23 22:21:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73d9d4ac7b327770e2b8a4d8782a...