[foozzie] Mock out stack traces

[foozzie] Mock out stack traces

BUG=chromium:683494
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org

Review-Url: https://codereview.chromium.org/2651713005
Cr-Commit-Position: refs/heads/master@{#42619}
Committed: https://chromium.googlesource.com/v8/v8/+/09163d71bd3e1074dfa8ed439c789b67ee797133

[Michael Achenbach, 2017-01-24 08:12:39]

Description was changed from

==========
[foozzie] Mock out stack traces

BUG=
==========

to

==========
[foozzie] Mock out stack traces

BUG=chromium:683494
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org
==========

[Michael Achenbach, 2017-01-24 08:12:39]

machenbach@chromium.org changed reviewers:
+ jarin@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2017-01-24 08:12:47]

PTAL

[Yang, 2017-01-24 08:15:26]

lgtm

[Michael Achenbach, 2017-01-24 08:16:20]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2017-01-24 08:16:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 08:18:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485245780031200, "parent_rev":
"8da82d30b861cdb6cc3c4276322a1592cb8ae4a2", "commit_rev":
"09163d71bd3e1074dfa8ed439c789b67ee797133"}

[commit-bot: I haz the power, 2017-01-24 08:18:10]

Description was changed from

==========
[foozzie] Mock out stack traces

BUG=chromium:683494
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org
==========

to

==========
[foozzie] Mock out stack traces

BUG=chromium:683494
NOTRY=true
TBR=yangguo@chromium.org, jarin@chromium.org

Review-Url: https://codereview.chromium.org/2651713005
Cr-Commit-Position: refs/heads/master@{#42619}
Committed:
https://chromium.googlesource.com/v8/v8/+/09163d71bd3e1074dfa8ed439c789b67ee7...
==========

[commit-bot: I haz the power, 2017-01-24 08:18:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/09163d71bd3e1074dfa8ed439c789b67ee7...

[Yang, 2017-01-24 08:23:59]

not sure if you want to make it not writable so that it cannot be overwritten.

[Michael Achenbach, 2017-01-24 08:48:17]

On 2017/01/24 08:23:59, Yang wrote:
> not sure if you want to make it not writable so that it cannot be overwritten.

Would that be Object.freeze(Error) ? Or is there a way to only make the
prepareStackTrace property immutable?

[Michael Achenbach, 2017-01-24 08:49:29]

On 2017/01/24 08:48:17, Michael Achenbach wrote:
> On 2017/01/24 08:23:59, Yang wrote:
> > not sure if you want to make it not writable so that it cannot be
overwritten.
> 
> Would that be Object.freeze(Error) ? Or is there a way to only make the
> prepareStackTrace property immutable?

On the other hand, with the line I added, the internal prepareStackTrace is gone
right? If a test case overwrites it with yet another thing, it should be
deterministic between our compilers, or not?

[Yang, 2017-01-24 08:50:53]

On 2017/01/24 08:49:29, Michael Achenbach wrote:
> On 2017/01/24 08:48:17, Michael Achenbach wrote:
> > On 2017/01/24 08:23:59, Yang wrote:
> > > not sure if you want to make it not writable so that it cannot be
> overwritten.
> > 
> > Would that be Object.freeze(Error) ? Or is there a way to only make the
> > prepareStackTrace property immutable?
> 
> On the other hand, with the line I added, the internal prepareStackTrace is
gone
> right? If a test case overwrites it with yet another thing, it should be
> deterministic between our compilers, or not?

Not sure. These tests do something with the frame objects. These again might be
platform dependent.

Let's just wait and see if that becomes an issue.