chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java - Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

index 0689c3843757f28a72ae7e91405d8cea5da83544..eaeb963abe6b2cdfb77fc939d96604ccb7f5de20 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

@@ -25,6 +25,7 @@ import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;

import org.chromium.chrome.browser.omnibox.LocationBarLayout;

import org.chromium.chrome.browser.omnibox.UrlBar;

+import org.chromium.chrome.browser.suggestions.TileGroupDelegateImpl;

import org.chromium.chrome.browser.tab.EmptyTabObserver;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.test.ChromeTabbedActivityTestBase;

@@ -99,7 +100,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {

} catch (Throwable t) {

fail(t.getMessage());

}

- NewTabPage.setMostVisitedSitesForTests(mFakeMostVisitedSites);

+ TileGroupDelegateImpl.setMostVisitedSitesForTests(mFakeMostVisitedSites);

loadUrl(UrlConstants.NTP_URL);

NewTabPageTestUtils.waitForNtpLoaded(mTab);

@@ -420,7 +421,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {

});

}

- private void waitForFakeboxFocusAnimationComplete(NewTabPage ntp) throws InterruptedException {

+ private void waitForFakeboxFocusAnimationComplete(NewTabPage ntp) {

waitForUrlFocusPercent(ntp, 1f);

}