chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java - Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

index c66f2ed0106be3bb72d325fea8a834b43d81374b..1e7295538e9e12ee3f76e6e74fb054c288e1b42c 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

@@ -26,6 +26,7 @@ import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsCardLayout;

import org.chromium.chrome.browser.ntp.snippets.FakeSuggestionsSource;

import org.chromium.chrome.browser.ntp.snippets.KnownCategories;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

+import org.chromium.chrome.browser.suggestions.TileGroupDelegateImpl;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.test.ChromeTabbedActivityTestBase;

import org.chromium.chrome.test.util.ChromeTabUtils;

@@ -75,7 +76,7 @@ public class NewTabPageRecyclerViewTest extends ChromeTabbedActivityTestBase {

@Override

protected void tearDown() throws Exception {

- NewTabPage.setMostVisitedSitesForTests(null);

+ TileGroupDelegateImpl.setMostVisitedSitesForTests(null);

NewTabPage.setSuggestionsSourceForTests(null);

mTestServer.stopAndDestroyServer();

@@ -97,7 +98,7 @@ public class NewTabPageRecyclerViewTest extends ChromeTabbedActivityTestBase {

FAKE_MOST_VISITED_WHITELIST_ICON_PATHS, FAKE_MOST_VISITED_SOURCES);

}

});

- NewTabPage.setMostVisitedSitesForTests(mFakeMostVisitedSites);

+ TileGroupDelegateImpl.setMostVisitedSitesForTests(mFakeMostVisitedSites);

loadUrl(UrlConstants.NTP_URL);

NewTabPageTestUtils.waitForNtpLoaded(mTab);