Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2651673009: s390: Fix DoArgumentsElements where should use CmpP (Closed)

Created:
3 years, 11 months ago by john.yan
Modified:
3 years, 11 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: Fix DoArgumentsElements where should use CmpP R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2651673009 Cr-Commit-Position: refs/heads/master@{#42663} Committed: https://chromium.googlesource.com/v8/v8/+/05426a0de30c1f676f9461c4a82b030072f5c7f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
john.yan
ptal
3 years, 11 months ago (2017-01-25 15:39:00 UTC) #1
john.yan
cc @JaideepBajwa This fixes should probably backport to previous versions.
3 years, 11 months ago (2017-01-25 15:40:40 UTC) #2
JoranSiu
On 2017/01/25 15:40:40, john.yan wrote: > cc @JaideepBajwa > This fixes should probably backport to ...
3 years, 11 months ago (2017-01-25 18:42:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651673009/1
3 years, 11 months ago (2017-01-25 18:44:06 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 18:46:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/05426a0de30c1f676f9461c4a82b030072f...

Powered by Google App Engine
This is Rietveld 408576698