Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2651673008: MD Downloads: make browser tests work with !use_vulcanize (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, asanka, chromium-reviews, dbeam+watch-downloads_chromium.org, michaelpg+watch-md-ui_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: make browser tests work with !use_vulcanize R=dpapad@chromium.org BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2651673008 Cr-Commit-Position: refs/heads/master@{#445931} Committed: https://chromium.googlesource.com/chromium/src/+/07014f0ad6eab4c567845429f84ac6e354c8adba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M chrome/browser/resources/md_downloads/item.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/md_downloads/downloads_browsertest.js View 3 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Beam
3 years, 11 months ago (2017-01-25 02:26:41 UTC) #2
dpapad
LGTM. Perhaps remove "our" from the description, seems redundant.
3 years, 11 months ago (2017-01-25 02:33:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651673008/1
3 years, 11 months ago (2017-01-25 02:35:54 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 03:34:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07014f0ad6eab4c567845429f84a...

Powered by Google App Engine
This is Rietveld 408576698