chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h - Issue 2651663003: Show human readable origin for Android apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

Issue 2651663003: Show human readable origin for Android apps (Closed)

Patch Set: Fix tests and nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc » ('j') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

index 830e8ba9a9887e0093acdf95556140a6b65c7ecc..842eb52a8be954cd1da6792470c5c8c23c3d2eb5 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h

@@ -43,7 +43,7 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,

void GetSavedPasswordsList(const UiEntriesCallback& callback) override;

void SendPasswordExceptionsList() override;

void GetPasswordExceptionsList(

- const ExceptionPairsCallback& callback) override;

+ const ExceptionEntriesCallback& callback) override;

void RemoveSavedPassword(

const std::string& origin_url, const std::string& username) override;

void RemovePasswordException(const std::string& exception_url) override;

@@ -98,7 +98,7 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,

// observers are added, this delegate can send the current lists without

// having to request them from |password_manager_presenter_| again.

UiEntries current_entries_;

- ExceptionPairs current_exceptions_;

+ ExceptionEntries current_exceptions_;

// Whether SetPasswordList and SetPasswordExceptionList have been called, and

// whether this class has been initialized, meaning both have been called.

@@ -112,7 +112,7 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,

// callbacks are invoked.

std::vector<base::Closure> pre_initialization_callbacks_;

std::vector<UiEntriesCallback> get_saved_passwords_list_callbacks_;

- std::vector<ExceptionPairsCallback> get_password_exception_list_callbacks_;

+ std::vector<ExceptionEntriesCallback> get_password_exception_list_callbacks_;

// The WebContents used when invoking this API. Used to fetch the

// NativeWindow for the window where the API was called.