chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h - Issue 2651663003: Show human readable origin for Android apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h

Issue 2651663003: Show human readable origin for Android apps (Closed)

Patch Set: Fix tests and nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h » ('j') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h

index 0cb1e04da72210b8cff4a267dec422de0d3fe8e0..15cfac7d522c5e156025b2f1773eaed5b998e6e8 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h

@@ -44,10 +44,11 @@ class PasswordsPrivateDelegate : public KeyedService {

virtual void SendPasswordExceptionsList() = 0;

// Gets the password exceptions list.

- using ExceptionPairs = std::vector<api::passwords_private::ExceptionPair>;

- using ExceptionPairsCallback = base::Callback<void(const ExceptionPairs&)>;

+ using ExceptionEntries = std::vector<api::passwords_private::ExceptionEntry>;

+ using ExceptionEntriesCallback =

+ base::Callback<void(const ExceptionEntries&)>;

virtual void GetPasswordExceptionsList(

- const ExceptionPairsCallback& callback) = 0;

+ const ExceptionEntriesCallback& callback) = 0;

// Removes the saved password entry corresponding to |origin_url| and

// |username|.