Convert more AudioNode tests to use testharness

Convert more AudioNode tests to use testharness

Manually convert the tests to use testharness.  Since we need to
replace the js-test stuff as well, the file was converted to use new
Audit too.

BUG=682011
TEST=audionode.html, audionode-channel-rules.html, audionode-connect-order.html

Review-Url: https://codereview.chromium.org/2651623004
Cr-Commit-Position: refs/heads/master@{#446747}
Committed: https://chromium.googlesource.com/chromium/src/+/89cb5871b5678f3931845d58bab298e46ae5e64b

[Raymond Toy, 2017-01-23 21:47:19]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-23 21:47:20]

PTAL

[hongchan, 2017-01-23 21:50:56]

https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html (right):

https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html:30:
"AudioBufferSource.numberOfInputs")
Sorry to be picky, but the indentation is not aligned. Same for the below.

https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html:69: context3 =
new AudioContext(1, 44100, 44100),
This line needs to go up.

[Raymond Toy, 2017-01-23 22:14:42]

https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html (right):

https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html:30:
"AudioBufferSource.numberOfInputs")
On 2017/01/23 21:50:56, hongchan wrote:
> Sorry to be picky, but the indentation is not aligned. Same for the below.

You are supposed to be picky.

This is what js-beautify does.

However, if you're happy with the code, ignoring indentation issues, I think I
should also reindent everything to 2 spaces instead of 4.

https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html:69: context3 =
new AudioContext(1, 44100, 44100),
On 2017/01/23 21:50:56, hongchan wrote:
> This line needs to go up.

Another js-beautify issue, so same comment as above.

[Raymond Toy, 2017-01-23 22:43:36]

On 2017/01/23 22:14:42, Raymond Toy wrote:
>
https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html (right):
> 
>
https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html:30:
> "AudioBufferSource.numberOfInputs")
> On 2017/01/23 21:50:56, hongchan wrote:
> > Sorry to be picky, but the indentation is not aligned. Same for the below.
> 
> You are supposed to be picky.
> 
> This is what js-beautify does.
> 
> However, if you're happy with the code, ignoring indentation issues, I think I
> should also reindent everything to 2 spaces instead of 4.
> 
>
https://codereview.chromium.org/2651623004/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html:69: context3
=
> new AudioContext(1, 44100, 44100),
> On 2017/01/23 21:50:56, hongchan wrote:
> > This line needs to go up.
> 
> Another js-beautify issue, so same comment as above.

Reindent with clang-format.

[hongchan, 2017-01-23 23:12:58]

looks good in general, but we'll need to check if ES6 function notation does not
do anything weird.

https://codereview.chromium.org/2651623004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html (right):

https://codereview.chromium.org/2651623004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html:45: should(() =
> audioNode.connect(0, 0, 0), 'audioNode.connect(0, 0, 0)')
Hmm. Is this okay? |() = >|

Does it run by V8 without an error?

[hongchan, 2017-01-27 18:58:16]

lgtm

[Raymond Toy, 2017-01-27 18:58:48]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 20:16:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485543528751250,
"parent_rev": "6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127", "commit_rev":
"89cb5871b5678f3931845d58bab298e46ae5e64b"}

[commit-bot: I haz the power, 2017-01-27 20:17:14]

Description was changed from

==========
Convert more AudioNode tests to use testharness

Manually convert the tests to use testharness.  Since we need to
replace the js-test stuff as well, the file was converted to use new
Audit too.

BUG=682011
TEST=audionode.html, audionode-channel-rules.html, audionode-connect-order.html
==========

to

==========
Convert more AudioNode tests to use testharness

Manually convert the tests to use testharness.  Since we need to
replace the js-test stuff as well, the file was converted to use new
Audit too.

BUG=682011
TEST=audionode.html, audionode-channel-rules.html, audionode-connect-order.html

Review-Url: https://codereview.chromium.org/2651623004
Cr-Commit-Position: refs/heads/master@{#446747}
Committed:
https://chromium.googlesource.com/chromium/src/+/89cb5871b5678f3931845d58bab2...
==========

[commit-bot: I haz the power, 2017-01-27 20:17:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/89cb5871b5678f3931845d58bab2...