Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2651563004: [sync] Add model type counters to memory dumps. (Closed)

Created:
3 years, 11 months ago by DmitrySkiba
Modified:
3 years, 11 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Add model type counters to memory dumps. crbug.com/675682 reported that in some rare cases sync uses enormous amounts of memory. To correlate memory usage with size of user's profile, this CL adds model type counters to memory dumps. BUG=675683 Review-Url: https://codereview.chromium.org/2651563004 Cr-Commit-Position: refs/heads/master@{#445795} Committed: https://chromium.googlesource.com/chromium/src/+/65f48321e20afaa5ac2f11a2546cf33e791fe570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M components/sync/syncable/directory.cc View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
DmitrySkiba
Example dump: sync 0xD7364A90 kernel 2,437.9 KiB store 57.3 KiB model_type APP 0 APP_LIST 0 ...
3 years, 11 months ago (2017-01-23 19:53:12 UTC) #2
pavely
lgtm
3 years, 11 months ago (2017-01-24 18:54:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651563004/1
3 years, 11 months ago (2017-01-24 19:01:04 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 20:40:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65f48321e20afaa5ac2f11a2546c...

Powered by Google App Engine
This is Rietveld 408576698