Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2651563002:
Extensions handler: OnCheckMediaFile is not used (Closed)
|
Created:
3 years, 11 months ago by Noel Gordon Modified:
3 years, 9 months ago CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExtensions handler: OnCheckMediaFile is not used
CheckMediaFile is all mojo now. OnCheckMediaFile is an orphan
and unused, remove it.
BUG=680928
Review-Url: https://codereview.chromium.org/2651563002
Cr-Commit-Position: refs/heads/master@{#445716}
Committed: https://chromium.googlesource.com/chromium/src/+/673842136e3567693a64c20dc6aa7b9530b26abc
Patch Set 1 #
Messages
Total messages: 30 (21 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now, so OnCheckMediaFile can go. BUG= ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now, OnCheckMediaFile is an orphan and unused: ditch it. BUG= ==========
noel@chromium.org changed reviewers: + sammc@google.com, tommycli@chromium.org
+sam - for a general nod. +tommy for media galleries
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now, OnCheckMediaFile is an orphan and unused: ditch it. BUG= ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused: ditch it. BUG= ==========
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused: ditch it. BUG= ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused: ditch it. BUG=680928 ==========
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused: ditch it. BUG=680928 ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused; ditch it. BUG=680928 ==========
sammc@chromium.org changed reviewers: + sammc@chromium.org
lgtm
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused; ditch it. BUG=680928 ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused; remove it. BUG=680928 ==========
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now: OnCheckMediaFile is an orphan and unused; remove it. BUG=680928 ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now. OnCheckMediaFile is an orphan and unused, remove it. BUG=680928 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was unchecked by noel@chromium.org
noel@chromium.org changed reviewers: + jochen@chromium.org
+jochen for OWNERS
lgtm
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485264217236930, "parent_rev":
"fb44744e06573d880f3c99d1aec1e960bb18dc31", "commit_rev":
"673842136e3567693a64c20dc6aa7b9530b26abc"}
Message was sent while issue was closed.
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now. OnCheckMediaFile is an orphan and unused, remove it. BUG=680928 ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now. OnCheckMediaFile is an orphan and unused, remove it. BUG=680928 Review-Url: https://codereview.chromium.org/2651563002 Cr-Commit-Position: refs/heads/master@{#445716} Committed: https://chromium.googlesource.com/chromium/src/+/673842136e3567693a64c20dc6aa... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/673842136e3567693a64c20dc6aa...
Message was sent while issue was closed.
Description was changed from ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now. OnCheckMediaFile is an orphan and unused, remove it. BUG=680928 Review-Url: https://codereview.chromium.org/2651563002 Cr-Commit-Position: refs/heads/master@{#445716} Committed: https://chromium.googlesource.com/chromium/src/+/673842136e3567693a64c20dc6aa... ========== to ========== Extensions handler: OnCheckMediaFile is not used CheckMediaFile is all mojo now. OnCheckMediaFile is an orphan and unused, remove it. BUG=680928 Review-Url: https://codereview.chromium.org/2651563002 Cr-Commit-Position: refs/heads/master@{#445716} Committed: https://chromium.googlesource.com/chromium/src/+/673842136e3567693a64c20dc6aa... ==========
Message was sent while issue was closed.
noel@chromium.org changed reviewers: - sammc@google.com |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
