numberOfErrors are not defined in should().beEqualToArray()

numberOfErrors are not defined in should().beEqualToArray()

The variable |numberOfErrors| is not defined in should()
.beEqualToArray(). It also prints out "0 more errors..."
when it's more than 0.

This CL fixes the issue.

BUG=685261
TEST=
LayoutTests/webaudio/unit-tests/audit-failures.html

Review-Url: https://codereview.chromium.org/2651553007
Cr-Commit-Position: refs/heads/master@{#446188}
Committed: https://chromium.googlesource.com/chromium/src/+/07749b1ba2fc232cb07f851efd5409cf96795deb

[hongchan, 2017-01-25 18:43:41]

Description was changed from

==========
numberOfErrors are not defined in should().beEqualToArray()

The variable |numberOfErrors| is not defined in should()
.beEqualToArray(). It also prints out "0 more errors..."
when it's more than 0.

This CL fixes the issue.

BUG=685261
TEST=
LayoutTests/webaudio/unit-tests/audit-failures.html
==========

to

==========
numberOfErrors are not defined in should().beEqualToArray()

The variable |numberOfErrors| is not defined in should()
.beEqualToArray(). It also prints out "0 more errors..."
when it's more than 0.

This CL fixes the issue.

BUG=685261
TEST=
LayoutTests/webaudio/unit-tests/audit-failures.html
==========

[hongchan, 2017-01-25 18:43:41]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-01-25 18:44:26]

PTAL.

[Raymond Toy, 2017-01-25 19:42:07]

lgtm with nits

https://codereview.chromium.org/2651553007/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
(right):

https://codereview.chromium.org/2651553007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html:58:
.beEqualToArray([1, 8, 9, 18, 6, 5, 6, 5, 123, 48]);
Although there's nothing wrong with this change, but why not just keep the
change smaller and only change one of the arrays?

And actually since the contents don't really matter, why not make the reference
a simple linear ramp?  That makes it obvious what's wrong with the actual data
compared to the reference.

[hongchan, 2017-01-25 22:20:33]

https://codereview.chromium.org/2651553007/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
(right):

https://codereview.chromium.org/2651553007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html:58:
.beEqualToArray([1, 8, 9, 18, 6, 5, 6, 5, 123, 48]);
On 2017/01/25 19:42:07, Raymond Toy wrote:
> Although there's nothing wrong with this change, but why not just keep the
> change smaller and only change one of the arrays?
> 
> And actually since the contents don't really matter, why not make the
reference
> a simple linear ramp?  That makes it obvious what's wrong with the actual data
> compared to the reference.

Done.

[hongchan, 2017-01-25 22:20:38]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-01-25 22:20:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2651553007/#ps20001
(title: "fixed the expected result after l-g-t-m")

[commit-bot: I haz the power, 2017-01-25 22:21:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 23:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:58:17]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hongchan, 2017-01-26 00:05:06]

The CQ bit was checked by hongchan@chromium.org

[commit-bot: I haz the power, 2017-01-26 00:05:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 01:16:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485389106527400,
"parent_rev": "c6e43b7acabc17ec431debcad4228cc950166f1b", "commit_rev":
"07749b1ba2fc232cb07f851efd5409cf96795deb"}

[commit-bot: I haz the power, 2017-01-26 01:17:00]

Description was changed from

==========
numberOfErrors are not defined in should().beEqualToArray()

The variable |numberOfErrors| is not defined in should()
.beEqualToArray(). It also prints out "0 more errors..."
when it's more than 0.

This CL fixes the issue.

BUG=685261
TEST=
LayoutTests/webaudio/unit-tests/audit-failures.html
==========

to

==========
numberOfErrors are not defined in should().beEqualToArray()

The variable |numberOfErrors| is not defined in should()
.beEqualToArray(). It also prints out "0 more errors..."
when it's more than 0.

This CL fixes the issue.

BUG=685261
TEST=
LayoutTests/webaudio/unit-tests/audit-failures.html

Review-Url: https://codereview.chromium.org/2651553007
Cr-Commit-Position: refs/heads/master@{#446188}
Committed:
https://chromium.googlesource.com/chromium/src/+/07749b1ba2fc232cb07f851efd54...
==========

[commit-bot: I haz the power, 2017-01-26 01:17:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/07749b1ba2fc232cb07f851efd54...