Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2651553006:
Dependency check for .proto files is added to PRESUBMIT (Closed)
|
Created:
3 years, 11 months ago by Ramin Halavati Modified:
3 years, 8 months ago Reviewers:
brettw CC:
chromium-reviews, xyzzyz Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDependancy check for .proto files is added to PRESUBMIT.
In a separate CL (https://codereview.chromium.org/2653023004/) I have added proto dependancy check to buildtools. This CL updates PRESUBMIT to use them.
BUG=684383
Review-Url: https://codereview.chromium.org/2651553006
Cr-Commit-Position: refs/heads/master@{#461380}
Committed: https://chromium.googlesource.com/chromium/src/+/08acd23b2515d32a9f107a5d71555d7b2270c0f8
Patch Set 1 #Patch Set 2 : nits #
Messages
Total messages: 18 (13 generated)
Description was changed from ========== Dependancy check for .proto files is added. PRESUBMIT and checkdeps are modified so that import lines in proto files are checked for matching with rules stated in DEPS file. BUG=684383 ========== to ========== Dependancy check for .proto files is added to PRESUBMIT. In a separate CL (https://codereview.chromium.org/2653023004/) I have added proto dependancy check to buildtools. This CL updates PRESUBMIT to use them. BUG=684383 ==========
rhalavati@chromium.org changed reviewers: + brettw@chromium.org
Hi, In a separate CL (https://codereview.chromium.org/2653023004/) I have added proto dependency check to buildtools. This CL updates PRESUBMIT to use them. Please review.
The CQ bit was checked by rhalavati@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/01/25 11:06:49, Ramin Halavati wrote: > Hi, > > In a separate CL (https://codereview.chromium.org/2653023004/) I have added > proto dependency check to buildtools. This CL updates PRESUBMIT to use them. > > Please review. Hi, A while ago I added proto files dependency checker to build tools, but updating PRESUBMIT.py to use it was left not reviewed. Please check it. This updated extracts modified import lines in proto files and passes them to ProtoChecker, the same way that modified include files are passed to CppChecker.
lgtm
The CQ bit was checked by rhalavati@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rhalavati@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491203993802930,
"parent_rev": "f97f2a165d8806024a90c8ee3a9b68ee0a4d06da", "commit_rev":
"08acd23b2515d32a9f107a5d71555d7b2270c0f8"}
Message was sent while issue was closed.
Description was changed from ========== Dependancy check for .proto files is added to PRESUBMIT. In a separate CL (https://codereview.chromium.org/2653023004/) I have added proto dependancy check to buildtools. This CL updates PRESUBMIT to use them. BUG=684383 ========== to ========== Dependancy check for .proto files is added to PRESUBMIT. In a separate CL (https://codereview.chromium.org/2653023004/) I have added proto dependancy check to buildtools. This CL updates PRESUBMIT to use them. BUG=684383 Review-Url: https://codereview.chromium.org/2651553006 Cr-Commit-Position: refs/heads/master@{#461380} Committed: https://chromium.googlesource.com/chromium/src/+/08acd23b2515d32a9f107a5d7155... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/08acd23b2515d32a9f107a5d7155... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
