Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2651553003: [deoptimizer] Materialize string iterators. (Closed)

Created:
3 years, 11 months ago by Jarin
Modified:
3 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Materialize string iterators. BUG=chromium:683617 Review-Url: https://codereview.chromium.org/2651553003 Cr-Commit-Position: refs/heads/master@{#42606} Committed: https://chromium.googlesource.com/v8/v8/+/6d1894e4f4a63a165b5bfcae414bd7137e01f8d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/deoptimizer.cc View 2 chunks +18 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-683617.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Jarin
Could you take a look, please?
3 years, 11 months ago (2017-01-23 13:11:54 UTC) #6
Michael Starzinger
LGTM.
3 years, 11 months ago (2017-01-23 13:13:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651553003/1
3 years, 11 months ago (2017-01-23 13:17:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21335) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-23 13:17:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651553003/1
3 years, 11 months ago (2017-01-23 16:26:40 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:46:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6d1894e4f4a63a165b5bfcae414bd7137e0...

Powered by Google App Engine
This is Rietveld 408576698