Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2651553002: X87: [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (reland). (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
chunyang.dai, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (reland). port 95a9b7611596865d2bea23fde24d0687d8ad0721 (r42344) original commit message: Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. BUG= Review-Url: https://codereview.chromium.org/2651553002 Cr-Commit-Position: refs/heads/master@{#42585} Committed: https://chromium.googlesource.com/v8/v8/+/761df3ca528e5ed999e6ef4e90ebbad259005158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +44 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-23 01:44:32 UTC) #2
chunyang.dai
On 2017/01/23 01:44:32, zhengxing.li wrote: > PTAL, thanks! LGTM thanks
3 years, 11 months ago (2017-01-23 02:06:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651553002/1
3 years, 11 months ago (2017-01-23 02:08:06 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 02:29:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/761df3ca528e5ed999e6ef4e90ebbad2590...

Powered by Google App Engine
This is Rietveld 408576698