Use explicit WebString conversions in spellcheck

Use explicit WebString conversions in spellcheck

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also in some files WebString implicit conversions seem to be used
just to get base::string16, this CL also replaces them with base's
string16 conversion methods.

BUG=667131
Review-Url: https://codereview.chromium.org/2651503003
Cr-Commit-Position: refs/heads/master@{#445570}
Committed: https://chromium.googlesource.com/chromium/src/+/20d134648b8ad14490e40e0b2e41aadb604e3939

[kinuko, 2017-01-23 04:34:31]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 04:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-01-23 04:36:27]

Description was changed from

==========
Use explicit WebString conversions in spellcheck

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also in some files WebString implicit conversions seem to be used
just to get base::string16, this CL also replaces them with base's
string16 conversion methods.

BUG=667131
==========

to

==========
Use explicit WebString conversions in spellcheck

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also in some files WebString implicit conversions seem to be used
just to get base::string16, this CL also replaces them with base's
string16 conversion methods.

BUG=667131
==========

[kinuko, 2017-01-23 04:36:27]

kinuko@chromium.org changed reviewers:
+ rouslan@chromium.org

[kinuko, 2017-01-23 04:37:49]

Hi, can you review this?

https://codereview.chromium.org/2651503003/diff/1/components/spellcheck/rende...
File components/spellcheck/renderer/spellcheck.cc (right):

https://codereview.chromium.org/2651503003/diff/1/components/spellcheck/rende...
components/spellcheck/renderer/spellcheck.cc:404: misspelling_start,
misspelling_length));
If we omit replacement parameter the ctor will use empty WebString (and that's
what we want)

[commit-bot: I haz the power, 2017-01-23 05:29:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 05:29:25]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-01-23 13:32:09]

spellcheck lgtm

[kinuko, 2017-01-24 00:36:11]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:37:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:43:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485218171984430, "parent_rev":
"0073e7c8e416685bfa479638a2ae05f8b217d434", "commit_rev":
"20d134648b8ad14490e40e0b2e41aadb604e3939"}

[commit-bot: I haz the power, 2017-01-24 00:44:26]

Description was changed from

==========
Use explicit WebString conversions in spellcheck

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also in some files WebString implicit conversions seem to be used
just to get base::string16, this CL also replaces them with base's
string16 conversion methods.

BUG=667131
==========

to

==========
Use explicit WebString conversions in spellcheck

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also in some files WebString implicit conversions seem to be used
just to get base::string16, this CL also replaces them with base's
string16 conversion methods.

BUG=667131

Review-Url: https://codereview.chromium.org/2651503003
Cr-Commit-Position: refs/heads/master@{#445570}
Committed:
https://chromium.googlesource.com/chromium/src/+/20d134648b8ad14490e40e0b2e41...
==========

[commit-bot: I haz the power, 2017-01-24 00:44:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20d134648b8ad14490e40e0b2e41...