chrome/browser/resources/settings/internet_page/network_property_list.js - Issue 2651483002: MD Settings: Eliminate use of ES6 for Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_property_list.js

Issue 2651483002: MD Settings: Eliminate use of ES6 for Chrome OS (Closed)

Patch Set: Feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/network_nameservers.js ('K') | « chrome/browser/resources/settings/internet_page/network_nameservers.js ('k') | chrome/browser/resources/settings/internet_page/network_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_property_list.js

diff --git a/chrome/browser/resources/settings/internet_page/network_property_list.js b/chrome/browser/resources/settings/internet_page/network_property_list.js

index c82744b89b72a6bace295bffad1f9875f9f39ca6..d64e6225395d45b7563c9c923de695370ae7b790 100644

--- a/chrome/browser/resources/settings/internet_page/network_property_list.js

+++ b/chrome/browser/resources/settings/internet_page/network_property_list.js

@@ -91,8 +91,8 @@ Polymer({

// We do not provide translations for every possible network property key.

// For keys specific to a type, strip the type prefix.

var result = prefix + key;

- for (let entry in chrome.networkingPrivate.NetworkType) {

- let type = chrome.networkingPrivate.NetworkType[entry];

+ for (var entry in chrome.networkingPrivate.NetworkType) {

+ var type = chrome.networkingPrivate.NetworkType[entry];

if (result.startsWith(type + '.')) {

result = result.substr(type.length + 1);

break;

@@ -160,7 +160,7 @@ Polymer({

if (typeof value == 'number' || typeof value == 'boolean')

return value.toString();

assert(typeof value == 'string');

- let valueStr = /** @type {string} */ (value);

+ var valueStr = /** @type {string} */ (value);

var oncKey = 'Onc' + prefix + key;

oncKey = oncKey.replace(/\./g, '-');

oncKey += '_' + valueStr;