Chromium Code Reviews| Index: chrome/browser/resources/settings/internet_page/network_nameservers.js |
| diff --git a/chrome/browser/resources/settings/internet_page/network_nameservers.js b/chrome/browser/resources/settings/internet_page/network_nameservers.js |
| index 1dd03da514c1aa778e09d249e4dbd8282b62e725..1429517cf9fd2e0e77a735242cb7e475205b273b 100644 |
| --- a/chrome/browser/resources/settings/internet_page/network_nameservers.js |
| +++ b/chrome/browser/resources/settings/internet_page/network_nameservers.js |
| @@ -110,7 +110,7 @@ Polymer({ |
| setNameservers_: function(nameserversType, nameservers) { |
| if (nameserversType == 'custom') { |
| // Add empty entries for unset custom nameservers. |
| - for (let i = nameservers.length; i < this.MAX_NAMESERVERS; ++i) |
| + for (var i = nameservers.length; i < this.MAX_NAMESERVERS; ++i) |
| nameservers[i] = ''; |
| } |
| this.nameservers_ = nameservers; |
| @@ -153,8 +153,8 @@ Polymer({ |
| onTypeChange_: function(event) { |
| if (this.nameserversType_ == 'custom') |
| this.savedNameservers_ = this.nameservers_; |
| - let target = /** @type {!HTMLSelectElement} */ (event.target); |
| - let type = target.value; |
| + var target = /** @type {!HTMLSelectElement} */ (event.target); |
| + var type = target.value; |
| this.nameserversType_ = type; |
| if (type == 'custom') { |
| // Restore the saved nameservers. |
| @@ -187,24 +187,19 @@ Polymer({ |
| var type = this.nameserversType_; |
| if (type == 'custom') { |
| - let nameservers = []; |
| - for (let i = 0; i < this.MAX_NAMESERVERS; ++i) { |
| - let id = 'nameserver' + i; |
| - let nameserverInput = this.$$('#' + id); |
| - let nameserver = ''; |
| - if (nameserverInput) |
| - nameserver = this.$$('#' + id).value; |
| - nameservers.push(nameserver); |
| + var nameservers = new Array(this.MAX_NAMESERVERS); |
| + for (var i = 0; i < this.MAX_NAMESERVERS; ++i) { |
|
dpapad
2017/01/24 02:38:10
Nit: Probably more robust to use nameservers.lengt
stevenjb
2017/01/24 02:59:52
Acknowledged.
|
| + var nameserverInput = this.$$('#nameserver' + i); |
| + nameservers[i] = nameserverInput ? nameserverInput.value : ''; |
| } |
| this.fire('nameservers-change', { |
| field: 'NameServers', |
| value: nameservers, |
| }); |
| } else if (type == 'google') { |
| - let nameservers = this.GOOGLE_NAMESERVERS; |
| this.fire('nameservers-change', { |
| field: 'NameServers', |
| - value: nameservers, |
| + value: this.GOOGLE_NAMESERVERS, |
| }); |
| } else { |
| // automatic |