Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2651433004: Last_n: Minor follow-up fixes post user interaction triggers. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/recent_tab_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/recent_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc
index dd75cd451bc8e454e7c8cd9064d8111708eb5d96..2231629bb90da2db9c6fc81bf27606d3dfd60bc5 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc
@@ -54,6 +54,8 @@ class DefaultDelegate: public offline_pages::RecentTabHelper::Delegate {
namespace offline_pages {
+using PageQuality = SnapshotController::PageQuality;
+
bool RecentTabHelper::SnapshotProgressInfo::IsForLastN() {
// A last_n snapshot always has an invalid request id.
return request_id == OfflinePageModel::kInvalidOfflineId;
@@ -135,7 +137,7 @@ bool RecentTabHelper::EnsureInitialized() {
void RecentTabHelper::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
- if (!navigation_handle->IsInMainFrame() || navigation_handle->IsSamePage() ||
+ if (!navigation_handle->IsInMainFrame() ||
!navigation_handle->HasCommitted()) {
return;
}
« no previous file with comments | « chrome/browser/android/offline_pages/recent_tab_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698