Move VR tests to separate APK

Move VR tests to separate APK

Moves VR instrumentation tests (currently just VR Shell, but will include WebVR
whenever those finally get added) to a separate test APK. This is in
preparation for the work to make VR instrumentation tests run continuously,
as the VR tests will need to run multiple times with different additional APKs
installed and different settings configured. It was decided in the meeting with
jbudorick@ that a separate APK would be better than using
chrome_public_test_apk with multiple --test-filter arguments.

Shouldn't affect anything other than our FYI bot.

BUG=671373
Review-Url: https://codereview.chromium.org/2651423002
Cr-Commit-Position: refs/heads/master@{#446566}
Committed: https://chromium.googlesource.com/chromium/src/+/9850866badcafcfd39db10e436217ca0d5bc8826

[bsheedy, 2017-01-26 18:41:10]

Description was changed from

==========
Move VR tests to separate APK

Moves VR instrumentation tests (currently just VR Shell, but will include WebVR
whenever those finally get added) to a separate test APK. This is in
preparation for the work to make VR instrumentation tests run continuously,
as the VR tests will need to run multiple times with different additional APKs
installed and different settings configured. It was decided in the meeting with
jbudorick@ that a separate APK would be better than using
chrome_public_test_apk with multiple --test-filter arguments.

BUG=671373
==========

to

==========
Move VR tests to separate APK

Moves VR instrumentation tests (currently just VR Shell, but will include WebVR
whenever those finally get added) to a separate test APK. This is in
preparation for the work to make VR instrumentation tests run continuously,
as the VR tests will need to run multiple times with different additional APKs
installed and different settings configured. It was decided in the meeting with
jbudorick@ that a separate APK would be better than using
chrome_public_test_apk with multiple --test-filter arguments.

Shouldn't affect anything other than our FYI bot.

BUG=671373
==========

[bsheedy, 2017-01-26 18:47:07]

bsheedy@chromium.org changed reviewers:
+ sky@chromium.org

[bsheedy, 2017-01-26 18:47:07]

PTAL

[sky, 2017-01-26 19:09:36]

I'm happy to review the buildbot change, but I'm not familiar with the android
build files. Can you get a local owner to review those changes?

[bsheedy, 2017-01-26 19:11:20]

bsheedy@chromium.org changed reviewers:
+ tedchoc@chromium.org

[bsheedy, 2017-01-26 19:11:40]

On 2017/01/26 19:09:36, sky wrote:
> I'm happy to review the buildbot change, but I'm not familiar with the android
> build files. Can you get a local owner to review those changes?

+tedchoc for chrome/android OWNERS

[Ted C, 2017-01-26 19:34:39]

lgtm

cc'ing jbudorick as well incase there are any recipe implications here

[sky, 2017-01-26 22:43:37]

https://codereview.chromium.org/2651423002/diff/1/testing/buildbot/chromium.f...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2651423002/diff/1/testing/buildbot/chromium.f...
testing/buildbot/chromium.fyi.json:233: "test": "chrome_public_test_vr_apk"
I believe you need to update /testing/buildbot/gn_isolate_map.pyl too.

[bsheedy, 2017-01-26 23:05:31]

On 2017/01/26 22:43:37, sky wrote:
>
https://codereview.chromium.org/2651423002/diff/1/testing/buildbot/chromium.f...
> File testing/buildbot/chromium.fyi.json (right):
> 
>
https://codereview.chromium.org/2651423002/diff/1/testing/buildbot/chromium.f...
> testing/buildbot/chromium.fyi.json:233: "test": "chrome_public_test_vr_apk"
> I believe you need to update /testing/buildbot/gn_isolate_map.pyl too.

I tried that earlier, but it failed presubmit checks, claiming that
chrome_public_test_vr_apk wasn't in any .json files. I seem to remember having a
comment on an old CL that it's only for swarming (so the gtest_tests category),
but this APK currently isn't being used on swarming. Can't find the CL with that
comment, though.

[sky, 2017-01-26 23:21:59]

Ok, LGTM

[jbudorick, 2017-01-26 23:22:49]

On 2017/01/26 19:34:39, Ted C wrote:
> lgtm
> 
> cc'ing jbudorick as well incase there are any recipe implications here

There shouldn't be.

[bsheedy, 2017-01-26 23:40:01]

The CQ bit was checked by bsheedy@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:41:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:14:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485474001601600, "parent_rev":
"b591e9436105509968d4cb5b427061b68206522e", "commit_rev":
"9850866badcafcfd39db10e436217ca0d5bc8826"}

[commit-bot: I haz the power, 2017-01-27 03:15:39]

Description was changed from

==========
Move VR tests to separate APK

Moves VR instrumentation tests (currently just VR Shell, but will include WebVR
whenever those finally get added) to a separate test APK. This is in
preparation for the work to make VR instrumentation tests run continuously,
as the VR tests will need to run multiple times with different additional APKs
installed and different settings configured. It was decided in the meeting with
jbudorick@ that a separate APK would be better than using
chrome_public_test_apk with multiple --test-filter arguments.

Shouldn't affect anything other than our FYI bot.

BUG=671373
==========

to

==========
Move VR tests to separate APK

Moves VR instrumentation tests (currently just VR Shell, but will include WebVR
whenever those finally get added) to a separate test APK. This is in
preparation for the work to make VR instrumentation tests run continuously,
as the VR tests will need to run multiple times with different additional APKs
installed and different settings configured. It was decided in the meeting with
jbudorick@ that a separate APK would be better than using
chrome_public_test_apk with multiple --test-filter arguments.

Shouldn't affect anything other than our FYI bot.

BUG=671373

Review-Url: https://codereview.chromium.org/2651423002
Cr-Commit-Position: refs/heads/master@{#446566}
Committed:
https://chromium.googlesource.com/chromium/src/+/9850866badcafcfd39db10e43621...
==========

[commit-bot: I haz the power, 2017-01-27 03:15:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9850866badcafcfd39db10e43621...