Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2651383002: Delete duplicate macro definition of EXPECT_POINT_EQ. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete duplicate macro definition of EXPECT_POINT_EQ. BUG=685688 Review-Url: https://codereview.chromium.org/2651383002 Cr-Commit-Position: refs/heads/master@{#446399} Committed: https://chromium.googlesource.com/chromium/src/+/ee915a77341510d15c397dce5094a826fe369e38

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 chunk +0 lines, -6 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
Łukasz Anforowicz
bokan@, can you PTAL? https://codereview.chromium.org/2651383002/diff/1/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp File third_party/WebKit/Source/web/tests/VisualViewportTest.cpp (left): https://codereview.chromium.org/2651383002/diff/1/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp#oldcode73 third_party/WebKit/Source/web/tests/VisualViewportTest.cpp:73: Identical macro definition is on ...
3 years, 11 months ago (2017-01-26 18:01:05 UTC) #4
bokan
lgtm, thanks!
3 years, 11 months ago (2017-01-26 18:01:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651383002/1
3 years, 11 months ago (2017-01-26 18:07:45 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 19:42:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee915a77341510d15c397dce5094...

Powered by Google App Engine
This is Rietveld 408576698