Removing SpeechRecognitionManager::HasAudioInputDevices() and ShowAudioInputSettings()

Removing SpeechRecognitionManager::HasAudioInputDevices() and ShowAudioInputSettings()
- They do not seem to be used in Chromium codebase;
- ShowAudioInputSettings() is not supported on Mac and ChromeOS.

May we break any external embedders by this? If so, how should we negotiate the change?
If not removed, HasAudioInputDevices() should become asynchronous.

BUG=672468
Review-Url: https://codereview.chromium.org/2651373002
Cr-Commit-Position: refs/heads/master@{#446653}
Committed: https://chromium.googlesource.com/chromium/src/+/087876b708dc280dcd15ffb69acd6244571527f1

[o1ka, 2017-01-26 14:54:10]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 14:54:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 15:06:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 15:06:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[o1ka, 2017-01-26 15:10:08]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 15:10:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 16:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 16:02:36]

Dry run: This issue passed the CQ dry run.

[o1ka, 2017-01-26 16:20:59]

olka@chromium.org changed reviewers:
+ dalecurtis@google.com, tommi@chromium.org

[o1ka, 2017-01-26 16:21:01]

PTAL: WDYT? :)

[DaleCurtis, 2017-01-26 17:24:46]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2017-01-26 17:24:47]

non owner lgtm, but I don't think I've ever known who the callers of those
methods were anyways :)

[DaleCurtis, 2017-01-26 17:26:03]

Re: Your embedder question, they can still use the AudioManager implementations
directly for non-speech things and I don't think we provide speech api to
embedders.

[tommi (sloooow) - chröme, 2017-01-26 18:08:31]

lgtm. I don't know if there's a good way to figure out dependencies, so
hopefully someone will let us know if things break.

[o1ka, 2017-01-27 09:29:05]

olka@chromium.org changed reviewers:
+ kinuko@chromium.org

[o1ka, 2017-01-27 09:29:05]

kinuko@chromium.org: Please RS changes in
content/browser/browser_main_loop.cc
content/public/browser/speech_recognition_manager.h

Thanks!

[kinuko, 2017-01-27 11:12:29]

lgtm

[o1ka, 2017-01-27 12:46:05]

The CQ bit was checked by olka@chromium.org

[commit-bot: I haz the power, 2017-01-27 12:46:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 12:50:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485521165559760,
"parent_rev": "78edd276bd7ef0baacfafc3eb3288dc447dc4243", "commit_rev":
"087876b708dc280dcd15ffb69acd6244571527f1"}

[commit-bot: I haz the power, 2017-01-27 12:50:48]

Description was changed from

==========
Removing SpeechRecognitionManager::HasAudioInputDevices() and
ShowAudioInputSettings()
- They do not seem to be used in Chromium codebase;
- ShowAudioInputSettings() is not supported on Mac and ChromeOS.

May we break any external embedders by this? If so, how should we negotiate the
change?
If not removed, HasAudioInputDevices() should become asynchronous.

BUG=672468
==========

to

==========
Removing SpeechRecognitionManager::HasAudioInputDevices() and
ShowAudioInputSettings()
- They do not seem to be used in Chromium codebase;
- ShowAudioInputSettings() is not supported on Mac and ChromeOS.

May we break any external embedders by this? If so, how should we negotiate the
change?
If not removed, HasAudioInputDevices() should become asynchronous.

BUG=672468

Review-Url: https://codereview.chromium.org/2651373002
Cr-Commit-Position: refs/heads/master@{#446653}
Committed:
https://chromium.googlesource.com/chromium/src/+/087876b708dc280dcd15ffb69acd...
==========

[commit-bot: I haz the power, 2017-01-27 12:50:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/087876b708dc280dcd15ffb69acd...