Get the device ID in getSettings()

Get the device ID in getSettings()

Gets the device ID (different from the track ID) in
MediaStreamTrack.getSettings(). This used to be faked.

BUG=617142
Review-Url: https://codereview.chromium.org/2651353002
Cr-Commit-Position: refs/heads/master@{#448236}
Committed: https://chromium.googlesource.com/chromium/src/+/4fb8fea42adb06710ff815dec59d1a812105f637

[hta - Chromium, 2017-01-26 11:18:55]

Description was changed from

==========
Get the device ID in getSettings()

Gets the device ID (different from the track ID) in
MediaStreamTrack.getSettings(). This used to be faked.

BUG=617142
==========

to

==========
Get the device ID in getSettings()

Gets the device ID (different from the track ID) in
MediaStreamTrack.getSettings(). This used to be faked.

BUG=617142
==========

[hta - Chromium, 2017-01-26 11:18:55]

hta@chromium.org changed reviewers:
+ jochen@chromium.org

[hta - Chromium, 2017-01-26 11:19:41]

hta@chromium.org changed reviewers:
+ miu@chromium.org

[hta - Chromium, 2017-01-26 11:21:01]

This is the (I think) uncontroversial part of the CL that miu did not like
(https://codereview.chromium.org/2645613005/)

Since this completes the settings that were promised in the Intent to Implement
& Ship, it seems worthwhile to land this one.

[jochen (gone - plz use gerrit), 2017-01-27 04:08:40]

I'll wait for miu@ to approve first

[miu, 2017-01-31 01:23:20]

lgtm. Thanks! :)

https://codereview.chromium.org/2651353002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp
(right):

https://codereview.chromium.org/2651353002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp:98:
m_trackData->getSettings(settings);
There was the earlier change to WebMediaStreamTrack::ExtraData as well. Are you
planning on addressing that in a future change?

https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebMe...

[hta - Chromium, 2017-02-06 01:33:01]

The CQ bit was checked by hta@chromium.org

[hta - Chromium, 2017-02-06 01:33:10]

https://codereview.chromium.org/2651353002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp
(right):

https://codereview.chromium.org/2651353002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp:98:
m_trackData->getSettings(settings);
On 2017/01/31 01:23:20, miu wrote:
> There was the earlier change to WebMediaStreamTrack::ExtraData as well. Are
you
> planning on addressing that in a future change?
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebMe...

I am staring at (in another CL) whether or not that pattern needs reversing -
there's a pattern already going "the other way" with regard to audio devices,
but utilizing that requires more thought than I thought, and the particular
change to WebMediaStreamTack::extraData -> trackData may actually still make
sense.

Let's take that in the review of that CL.

[commit-bot: I haz the power, 2017-02-06 01:33:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 01:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 01:39:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jochen (gone - plz use gerrit), 2017-02-06 09:38:30]

lgtm

[hta - Chromium, 2017-02-06 12:46:12]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2017-02-06 12:46:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 13:03:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486385172835850, "parent_rev":
"117ffb323637f7491cc6f4f87e33ff55d4256144", "commit_rev":
"4fb8fea42adb06710ff815dec59d1a812105f637"}

[commit-bot: I haz the power, 2017-02-06 13:03:47]

Description was changed from

==========
Get the device ID in getSettings()

Gets the device ID (different from the track ID) in
MediaStreamTrack.getSettings(). This used to be faked.

BUG=617142
==========

to

==========
Get the device ID in getSettings()

Gets the device ID (different from the track ID) in
MediaStreamTrack.getSettings(). This used to be faked.

BUG=617142

Review-Url: https://codereview.chromium.org/2651353002
Cr-Commit-Position: refs/heads/master@{#448236}
Committed:
https://chromium.googlesource.com/chromium/src/+/4fb8fea42adb06710ff815dec59d...
==========

[commit-bot: I haz the power, 2017-02-06 13:03:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4fb8fea42adb06710ff815dec59d...