Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2651333004: [Mac] Test for Content Setting Decoration (Closed)

Created:
3 years, 11 months ago by spqchan
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Test for Content Setting Decoration BUG=683823 Review-Url: https://codereview.chromium.org/2651333004 Cr-Commit-Position: refs/heads/master@{#446816} Committed: https://chromium.googlesource.com/chromium/src/+/fc363036700c132abd59176a2ca039c1fea3c5bc

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2016 -> 2017 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm View 1 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
spqchan
PTAL, thanks!
3 years, 10 months ago (2017-01-27 04:07:27 UTC) #6
Robert Sesek
LGTM. Thanks! https://codereview.chromium.org/2651333004/diff/1/chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm File chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm (right): https://codereview.chromium.org/2651333004/diff/1/chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm#newcode1 chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm:1: // Copyright 2016 The Chromium Authors. All ...
3 years, 10 months ago (2017-01-27 10:56:10 UTC) #7
spqchan
https://codereview.chromium.org/2651333004/diff/1/chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm File chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm (right): https://codereview.chromium.org/2651333004/diff/1/chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm#newcode1 chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 10 months ago (2017-01-27 18:38:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651333004/20001
3 years, 10 months ago (2017-01-27 18:39:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/222092)
3 years, 10 months ago (2017-01-27 21:40:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651333004/20001
3 years, 10 months ago (2017-01-27 21:40:55 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:11:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc363036700c132abd59176a2ca0...

Powered by Google App Engine
This is Rietveld 408576698