Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2651283002: Fix flakiness in TextureLayerImplWithMailboxThreadedCallback (Closed)

Created:
3 years, 11 months ago by ericrk
Modified:
3 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in TextureLayerImplWithMailboxThreadedCallback We used to rely on callbacks happening within one frame. Nothing guaranteed this. This change updates the logic so that progress in the test is driven by the callback. R=danakj@chromium.org BUG=680770 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2651283002 Cr-Commit-Position: refs/heads/master@{#446162} Committed: https://chromium.googlesource.com/chromium/src/+/ad5923814efe7dc0c236c7894955e3b696d73cd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -50 lines) Patch
M cc/layers/texture_layer_unittest.cc View 4 chunks +75 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ericrk
The "remove ForceReclaimResources" patch is on hold, pending some memory regression investigations. I had folded ...
3 years, 11 months ago (2017-01-25 22:03:15 UTC) #2
danakj
LGTM
3 years, 11 months ago (2017-01-25 22:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651283002/1
3 years, 11 months ago (2017-01-25 22:14:47 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 23:26:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad5923814efe7dc0c236c7894955...

Powered by Google App Engine
This is Rietveld 408576698