|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by RyanSturm Modified:
3 years, 11 months ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixing a histograms.xml typo
There is an additional "PageLoad" specified within the histogram.xml
view of recently added histograms for data reduction proxy page loads.
BUG=685372
Review-Url: https://codereview.chromium.org/2651273002
Cr-Commit-Position: refs/heads/master@{#446266}
Committed: https://chromium.googlesource.com/chromium/src/+/791c54b0a42f4915e712dc66ed981596214d19dd
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ryansturm@chromium.org changed reviewers: + asvitkine@chromium.org
asvitkine: PTAL, is this allowed to fix typos, or would obsolete'ing the old histograms be necessary? Thanks! https://codereview.chromium.org/2642553002/ is the faulty CL for reference.
lgtm
The CQ bit was unchecked by ryansturm@chromium.org
The CQ bit was checked by ryansturm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by ryansturm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by ryansturm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485413046452430, "parent_rev":
"ad966d06c75173598b84ce1150e7fea12fe7e1b8", "commit_rev":
"791c54b0a42f4915e712dc66ed981596214d19dd"}
Message was sent while issue was closed.
Description was changed from ========== Fixing a histograms.xml typo There is an additional "PageLoad" specified within the histogram.xml view of recently added histograms for data reduction proxy page loads. BUG=685372 ========== to ========== Fixing a histograms.xml typo There is an additional "PageLoad" specified within the histogram.xml view of recently added histograms for data reduction proxy page loads. BUG=685372 Review-Url: https://codereview.chromium.org/2651273002 Cr-Commit-Position: refs/heads/master@{#446266} Committed: https://chromium.googlesource.com/chromium/src/+/791c54b0a42f4915e712dc66ed98... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/791c54b0a42f4915e712dc66ed98... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
