Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2651273002: Fixing a histograms.xml typo (Closed)

Created:
3 years, 11 months ago by RyanSturm
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing a histograms.xml typo There is an additional "PageLoad" specified within the histogram.xml view of recently added histograms for data reduction proxy page loads. BUG=685372 Review-Url: https://codereview.chromium.org/2651273002 Cr-Commit-Position: refs/heads/master@{#446266} Committed: https://chromium.googlesource.com/chromium/src/+/791c54b0a42f4915e712dc66ed981596214d19dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tools/metrics/histograms/histograms.xml View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
RyanSturm
asvitkine: PTAL, is this allowed to fix typos, or would obsolete'ing the old histograms be ...
3 years, 11 months ago (2017-01-25 21:44:05 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-25 21:53:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651273002/1
3 years, 11 months ago (2017-01-25 21:54:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220257)
3 years, 11 months ago (2017-01-26 01:07:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651273002/1
3 years, 11 months ago (2017-01-26 01:11:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220609)
3 years, 11 months ago (2017-01-26 04:11:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651273002/1
3 years, 11 months ago (2017-01-26 06:44:25 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 07:24:25 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/791c54b0a42f4915e712dc66ed98...

Powered by Google App Engine
This is Rietveld 408576698