Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 2651263002: Add debug step check before break and continue (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "lib/invocation_mirror.h" 7 #include "lib/invocation_mirror.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 2086 matching lines...) Expand 10 before | Expand all | Expand 10 after
2097 exit_ = for_test.CreateFalseSuccessor(); 2097 exit_ = for_test.CreateFalseSuccessor();
2098 } else { 2098 } else {
2099 for_test.IfFalseGoto(nested_loop.break_target()); 2099 for_test.IfFalseGoto(nested_loop.break_target());
2100 exit_ = nested_loop.break_target(); 2100 exit_ = nested_loop.break_target();
2101 } 2101 }
2102 } 2102 }
2103 } 2103 }
2104 2104
2105 2105
2106 void EffectGraphVisitor::VisitJumpNode(JumpNode* node) { 2106 void EffectGraphVisitor::VisitJumpNode(JumpNode* node) {
2107 if (FLAG_support_debugger && owner()->function().is_debuggable()) {
2108 AddInstruction(new (Z) DebugStepCheckInstr(node->token_pos(),
2109 RawPcDescriptors::kRuntimeCall));
2110 }
2111
2107 NestedContextAdjustment context_adjustment(owner(), owner()->context_level()); 2112 NestedContextAdjustment context_adjustment(owner(), owner()->context_level());
2108 2113
2109 for (intptr_t i = 0; i < node->inlined_finally_list_length(); i++) { 2114 for (intptr_t i = 0; i < node->inlined_finally_list_length(); i++) {
2110 EffectGraphVisitor for_effect(owner()); 2115 EffectGraphVisitor for_effect(owner());
2111 node->InlinedFinallyNodeAt(i)->Visit(&for_effect); 2116 node->InlinedFinallyNodeAt(i)->Visit(&for_effect);
2112 Append(for_effect); 2117 Append(for_effect);
2113 if (!is_open()) return; 2118 if (!is_open()) return;
2114 } 2119 }
2115 2120
2116 // Unchain the context(s) up to the outer context level of the scope which 2121 // Unchain the context(s) up to the outer context level of the scope which
(...skipping 2216 matching lines...) Expand 10 before | Expand all | Expand 10 after
4333 graph_entry_->PruneUnreachable(graph_entry_, NULL, osr_id_, block_marks); 4338 graph_entry_->PruneUnreachable(graph_entry_, NULL, osr_id_, block_marks);
4334 ASSERT(found); 4339 ASSERT(found);
4335 } 4340 }
4336 4341
4337 4342
4338 void FlowGraphBuilder::Bailout(const char* reason) const { 4343 void FlowGraphBuilder::Bailout(const char* reason) const {
4339 parsed_function_.Bailout("FlowGraphBuilder", reason); 4344 parsed_function_.Bailout("FlowGraphBuilder", reason);
4340 } 4345 }
4341 4346
4342 } // namespace dart 4347 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698