Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2651253004: Convert non-Audit AudioParam tests to testharness (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert non-Audit AudioParam tests to testharness Manually convert js-test tests not using Audit and not using audioparam-testing.js to testharness and new Audit. BUG=685355 TEST= Review-Url: https://codereview.chromium.org/2651253004 Cr-Commit-Position: refs/heads/master@{#447064} Committed: https://chromium.googlesource.com/chromium/src/+/1b358ff908aa511571cb758016a50fa340d0b6e7

Patch Set 1 #

Patch Set 2 : Remove unneeded expected results. #

Total comments: 2

Patch Set 3 : Reindent #

Messages

Total messages: 11 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-01-27 19:21:09 UTC) #2
hongchan
I believe this is the result of clang-format. Correct? https://codereview.chromium.org/2651253004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html File third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html (right): https://codereview.chromium.org/2651253004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html#newcode4 third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html:4: ...
3 years, 10 months ago (2017-01-30 17:40:10 UTC) #3
Raymond Toy
https://codereview.chromium.org/2651253004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html File third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html (right): https://codereview.chromium.org/2651253004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html#newcode4 third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-connect-audioratesignal.html:4: Tests that an audio-rate signal (AudioNode output) can be ...
3 years, 10 months ago (2017-01-30 17:57:35 UTC) #4
Raymond Toy
On 2017/01/30 17:40:10, hongchan wrote: > I believe this is the result of clang-format. Correct? ...
3 years, 10 months ago (2017-01-30 18:04:27 UTC) #5
hongchan
lgtm
3 years, 10 months ago (2017-01-30 18:35:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651253004/40001
3 years, 10 months ago (2017-01-30 19:11:12 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 21:16:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1b358ff908aa511571cb758016a5...

Powered by Google App Engine
This is Rietveld 408576698