Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2651203006: wtf/Atomics.h: Remove Android/ARM kernel helpers. (Closed)

Created:
3 years, 10 months ago by digit1
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wtf/Atomics.h: Remove Android/ARM kernel helpers. Future Android kernels are going to remove the special page that is mapped in every process at a fixed address, and which provides optimized low-level operations. Instead of calling the memory helper related to memory barriers, use __sync_synchonize which will generate a DMB instruction directly, just like all other platforms (e.g. Linux/ARM). The only benefit of using the kernel helper was to avoid the DMB instruction on single-core devices, which are now totally obsolete. This change only impacts Android/ARM builds. BUG=686001 Review-Url: https://codereview.chromium.org/2651203006 Cr-Commit-Position: refs/heads/master@{#447008} Committed: https://chromium.googlesource.com/chromium/src/+/70847b53c7d1d5d8c65d526f966718a9e2c8adef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M third_party/WebKit/Source/wtf/Atomics.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
digit1
Hello haraken@, please review this change in wtf/Atomics.h
3 years, 10 months ago (2017-01-30 15:15:17 UTC) #7
haraken
LGTM
3 years, 10 months ago (2017-01-30 15:21:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651203006/1
3 years, 10 months ago (2017-01-30 15:26:47 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 17:41:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/70847b53c7d1d5d8c65d526f9667...

Powered by Google App Engine
This is Rietveld 408576698