Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2651173003: [cipd] Move ValidateRoot to common package (Closed)

Created:
3 years, 11 months ago by iannucci
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[cipd] Move ValidateRoot to common package It's where all the rest of the Validate methods live, and it'll be needed there in an upcoming CL. R=vadimsh@chromium.org BUG=663843 Review-Url: https://codereview.chromium.org/2651173003 Committed: https://github.com/luci/luci-go/commit/f4a47ebc3d3b3055862a252db22704995004e983

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -26 lines) Patch
M cipd/client/cipd/common/common.go View 2 chunks +25 lines, -0 lines 0 comments Download
M cipd/client/cipd/common/common_test.go View 1 2 chunks +45 lines, -0 lines 0 comments Download
M cipd/client/cipd/ensure/file.go View 3 chunks +1 line, -25 lines 0 comments Download
M cipd/client/cipd/ensure/item_parsers.go View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
iannucci
3 years, 11 months ago (2017-01-25 07:22:39 UTC) #1
Vadim Sh.
lgtm
3 years, 11 months ago (2017-01-25 18:24:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651173003/20001
3 years, 11 months ago (2017-01-25 19:49:46 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 19:56:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/f4a47ebc3d3b3055862a252db22704995004e983

Powered by Google App Engine
This is Rietveld 408576698