Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2651163002: Add UMA for autoblocking and embargoing. (Closed)
Patch Set: Sync branch, add test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index c00f3e7aa503570ad94c778a64b0b4923857aa9d..6f6da89a5c28183f8e2f73378915ef849d5d0288 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -289,6 +289,8 @@ void PermissionContextBase::PermissionDecided(
const BrowserPermissionCallback& callback,
bool persist,
ContentSetting content_setting) {
+ PermissionUmaUtil::RecordPermissionEmbargoReason(
dominickn 2017/01/30 02:41:36 Nit: add a comment saying: // If a decision was m
meredithl 2017/01/30 03:52:17 Done.
+ PermissionEmbargoReason::NOT_EMBARGOED);
dominickn 2017/01/30 02:41:36 You need to move this into an else case on line 32
meredithl 2017/01/30 03:52:17 Done.
if (PermissionRequestManager::IsEnabled()) {
// Infobar persistence and its related UMA is tracked on the infobar
// controller directly.

Powered by Google App Engine
This is Rietveld 408576698